Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detail pages should react to changing parameter values #288

Open
maraf opened this issue Sep 15, 2023 · 3 comments
Open

Detail pages should react to changing parameter values #288

maraf opened this issue Sep 15, 2023 · 3 comments
Assignees
@maraf
Labels
area-layout blazor bug Something isn't working code

Comments

@maraf
Copy link
Member

maraf commented Sep 15, 2023

Currently detail page components load data in OnInitializedAsync which doesn't reflect changing parameter values and navigation to the same page with different value (eg. link from being detail to being owner)
@maraf maraf added bug Something isn't working blazor code labels Sep 15, 2023
@maraf maraf added this to the v0.15.0 milestone Sep 15, 2023
@maraf maraf self-assigned this Sep 16, 2023
@maraf
Copy link
Member Author

maraf commented Sep 16, 2023

It's not only about detail components, but eg. Timeline has the same problem as it is used in being detail.

maraf added a commit that referenced this issue Sep 16, 2023
@maraf
#288 - Fix loading data in detail components.
90892c6
@maraf
Copy link
Member Author

maraf commented Sep 16, 2023

We need to maintain previous param values and check if they changed per-component. SetParametersAsync is called twice with the same values on hard reload.

maraf added a commit that referenced this issue Sep 16, 2023
@maraf
#288 - Refactor UserState init to base component.
52a6ed5
maraf added a commit that referenced this issue Oct 13, 2023
@maraf
#288 - Load timeline data only once in parallel.
335da7d
maraf added a commit that referenced this issue Oct 14, 2023
@maraf
#288 - Explicitly pass data or data getter to timeline component.
029568e
@maraf
Copy link
Member Author

maraf commented Oct 14, 2023

Fixed timeline. The rest is postponed for the moment.

@maraf maraf removed this from the v0.15.0 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraf maraf

Labels
area-layout blazor bug Something isn't working code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maraf