Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera transformations in ARKitScenes and ScanNet #1544

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Fix camera transformations in ARKitScenes and ScanNet #1544

merged 3 commits into from
Mar 2, 2023

Conversation

ponimatkin
Copy link
Contributor

@ponimatkin ponimatkin commented Mar 2, 2023

I realized there is a mistake in the conversion code since ARKitScenes and ScanNet use OpenCV camera convention, so there were a missing parts in the code – those are added now.

Edit: Given that there is PR #1543, maybe we should merge this patch with it?

Fix camera coordinate system in ARKitScenes.
Fix camera coordinates in ScanNet.
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit 63f5c8a into nerfstudio-project:main Mar 2, 2023
@ponimatkin ponimatkin deleted the fix-camera-coords branch March 2, 2023 19:35
jkulhanek pushed a commit that referenced this pull request Mar 10, 2023
* Update arkitscenes_dataparser.py

Fix camera coordinate system in ARKitScenes.

* Update scannet_dataparser.py

Fix camera coordinates in ScanNet.
@fanhongxing
Copy link

@ponimatkin When I used the 'ns-train nerfacto scannet-data --data ScanNet_path' command to train ScanNet scenes, I found that the scene were upside down. When I commented out 'pose[2, :] *= -1', the scene looked normal. Do you know why this is happening? If you could explain these lines of code for coordinate system transformation, it would be even better. Thank you for your work!

2023-04-17_231058.mp4

image

@ponimatkin
Copy link
Contributor Author

Hi @fanhongxing, ah I see, it seems I didn't order cameras correctly – when I was working on that PR I didn't have access to the viewer on my machines. I'll add a new PR soon to fix this issue for ScanNet and ARKitScenes.

@fanhongxing
Copy link

Hi @fanhongxing, ah I see, it seems I didn't order cameras correctly – when I was working on that PR I didn't have access to the viewer on my machines. I'll add a new PR soon to fix this issue for ScanNet and ARKitScenes.

@ponimatkin Thank you for your quick response! Looking forward to your excellent work.

chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
…ject#1544)

* Update arkitscenes_dataparser.py

Fix camera coordinate system in ARKitScenes.

* Update scannet_dataparser.py

Fix camera coordinates in ScanNet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants