Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in NEST Server #3319

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Sep 25, 2024

This PR refactors code to better coding structure because I always lost the overview of the old hl_api_server file.

Each file has clear definition:

  • hl_api_server: Main file with flask routes and flask configurations (app).
  • hl_api_server_helpers: Helper code (objects, functions) for the main file (without flask deps).
  • hl_api_server_utils: General code, similar to helpers but without nest imports.
  • hl_api_server_mpi: It includes MPI codes.

@gtrensch gtrensch added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 18, 2024
@babsey babsey changed the title Refactor code and better error handling in NEST Server Refactor code in NEST Server Nov 2, 2024
@babsey babsey added the P: Blocked Work on this can not continue, see comments for the particular reason label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) P: Blocked Work on this can not continue, see comments for the particular reason S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants