bugfix(common): prevent exception body override if message is an array

Author: Andrei Sîncrăian

packages/common/test/utils/http-exception-body.util.spec.ts

@@ -0,0 +1,16 @@
+import { expect } from 'chai';
+import { createHttpExceptionBody } from '../../utils/http-exception-body.util';
+
+describe('createHttpExceptionBody', () => {
+  it('should return pre-defined body if message is string', () => {
+    expect(createHttpExceptionBody('message', 'error', 200)).to.eql({ message: 'message', error: 'error', statusCode: 200 });
+  });
+
+  it('should override pre-defined body if message is object', () => {
+    expect(createHttpExceptionBody({ test: 'object' }, 'error', 200)).to.eql({ test: 'object' });
+  });
+
+  it('should not override pre-defined body if message is array', () => {
+    expect(createHttpExceptionBody(['a', 'random', 'array'], 'error', 200)).to.eql({ message: ['a', 'random', 'array'], error: 'error', statusCode: 200 });
+  });
+});

packages/common/utils/http-exception-body.util.ts

@@ -8,5 +8,5 @@ export const createHttpExceptionBody = (
   if (!message) {
     return { statusCode, error };
   }
-  return isObject(message) ? message : { statusCode, error, message };
+  return isObject(message) && !Array.isArray(message) ? message : { statusCode, error, message };
 };