feat: Support async local storage in interceptors #11142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow use cases such as allowing interceptors to
change the context in OpenTelemetry. You might for example want to add
Baggage to the context in an interceptor but because of the way it was
structured before the baggage would not make its way into the controller
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Before this change the context would be lost before the controller was called because of the deferred nature of the next call.
Issue Number: N/A
What is the new behavior?
This PR makes it possible to use
AsyncLocalStorage
from interceptors in such a way that the controller method will have access to the storage.Does this PR introduce a breaking change?
Not sure if it's a breaking change. If anyone relies on the interceptor chain running asap, but the controller being deferred this would be a breaking change. I find this a highly unlikely scenario so have put it down as a no.
Other information