Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pass application config to nest container when using application context #12166

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

SocketSomeone
Copy link
Contributor

@SocketSomeone SocketSomeone commented Jul 30, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #12165 #9017

NestContainer init w/o application config.
NestFactory.initialize take default value for application config. For that reason we got application config undefined and no global enhancers.

What is the new behavior?

After bootstrap application allow to create fns via ExternalContextCreator with global enhancers. For that we need to pass ApplicationConfig to container.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4338e9e0-055e-4201-9c62-52c00ec2f1d4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.813%

Totals Coverage Status
Change from base Build de330e86-7c2b-484a-b17f-f872998b5610: 0.0%
Covered Lines: 6392
Relevant Lines: 6887

💛 - Coveralls

@SocketSomeone SocketSomeone changed the title fix(core): pass application config to nest container fix(core): pass application config to nest container when using application context Jul 30, 2023
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 2cd7709 into nestjs:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants