[management] Consolidate network map firewall rules into summaries #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmmbaga
changed the base branch from
main
to
feature/network-route-access-control
bcmmbaga
force-pushed
the
mod-netmap-fw-sum
branch
from
95d01ec to
9f3fc12
Compare
|
|
Looks fine to me other than failed tests |
The failed tests are due to the missing client implementation after updating the proto definitions. |
lixmal
approved these changes
Aug 12, 2024
bcmmbaga
merged commit aa4e7a8
into
feature/network-route-access-control
7 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Optimizes the network map firewall routing rules by consolidating individual peer rules into summarized rule sets.
Issue ticket number and link
Checklist