Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtox: audit log spam due to blocked netlink #5277

Closed
JeremyMahieu opened this issue Jul 28, 2022 · 7 comments
Closed

qtox: audit log spam due to blocked netlink #5277

JeremyMahieu opened this issue Jul 28, 2022 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@JeremyMahieu
Copy link

JeremyMahieu commented Jul 28, 2022

Is your feature request related to a problem? Please describe.

In the profile for qtox only protocols inet, inet6, and unix are enabled while qtox is confined with seccomp. This leads to generation of seccomp violation reports since qtox also needs AF_NETLINK sockets.
The reports look like this:

Jul 28 11:17:03 XYZ audit[12345]: SECCOMP auid=1234 uid=1234 gid=1234 ses=1 subj==firejail-default (enforce) pid=12345 comm=<hash> exe="/usr/bin/qtox" sig=0 arch=bbbbbbbb syscall=41 compat=0 ip=0xaaaaaaaaaaaa code=0xababa

Describe the solution you'd like

This seemingly does not interfere with qtox's functionality but please consider adding netlink to permitted protocols in that profile.

Describe alternatives you've considered

Ignoring the seccomp violation messages, but they pollute the system journal and occur a few times every 10 seconds.

Additional context

The system should have Audit framework enabled and auditd running for logging to journal to happen. Systems configured otherwise will not see the same messages.

@glitsj16
Copy link
Collaborator

Describe alternatives you've considered
Ignoring the seccomp violation messages, but they pollute the system journal and occur a few times every 10 seconds.

One can always add netlink in a qtox.local override. But, IMO, when an application functions properly without it, and the issue is only journal spamming, users can add a rule to audit's configuration to silence these warnings. That way the sandbox is kept nicely tight and the irritating spamming is handled cleanly. Here's an example you can try in case of qtox:

$ cat /etc/audit/rules.d/20-dont-audit.rules

[...]
-a always,exclude -F exe=/usr/bin/qtox

Let's wait a bit to let other people give their opinion on how to proceed here (adding a comment on how to silence these warnings, or adding netlink to protocol).

@rusty-snake
Copy link
Collaborator

Journal spamming is already fixed (#5207).
If qtox works w/o netlink we should not weaken its profile for cosmetic reasons.

I would close as won't fix/duplicate.

@glitsj16 glitsj16 added duplicate This issue or pull request already exists wontfix This will not be worked on labels Jul 28, 2022
@glitsj16
Copy link
Collaborator

@JeremyMahieu So what the above comments boil down to is that the issue should be fixed in git already. Consult our wiki for instructions on how to build from git.

@kmk3
Copy link
Collaborator

kmk3 commented Jul 29, 2022

(Re-closing as "not planned", since it was marked as duplicate)

Duplicate of #5207.

Edit: For some reason, GitHub is not creating the "marked this as a
duplicate"
timeline event...

@kmk3 kmk3 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2022
@kmk3 kmk3 changed the title RFE qtox.profile qtox.profile spams audit logs due to blocked netlink Jul 29, 2022
@kmk3 kmk3 removed the wontfix This will not be worked on label Jul 29, 2022
@rusty-snake
Copy link
Collaborator

Edit: For some reason, GitHub is not creating the "marked this as a duplicate" timeline event...

It only does so if Duplicate of #1234 is the only text in your comment. Even a . at the end stops it IIRC.

@kmk3
Copy link
Collaborator

kmk3 commented Jul 29, 2022

Duplicate of #5207

@kmk3 kmk3 marked this as a duplicate of #5207 Jul 29, 2022
@kmk3
Copy link
Collaborator

kmk3 commented Jul 29, 2022

@rusty-snake commented on Jul 29:

Edit: For some reason, GitHub is not creating the "marked this as a
duplicate"

timeline event...

It only does so if Duplicate of #1234 is the only text in your comment.
Even a . at the end stops it IIRC.

Thanks! I had a hunch that it could be due to that, but I refused to believe
that it would be so brittle hehe.

I mean, even GitHub's own dependabot puts a dot at the end on similar
comments[1]:

Superseded by #XXX.

[1] kmk3#15 (comment)

@kmk3 kmk3 changed the title qtox.profile spams audit logs due to blocked netlink qtox: audit log spam due to blocked netlink Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants