Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new profile: mocp #3437

Merged
merged 5 commits into from
May 27, 2020
Merged

new profile: mocp #3437

merged 5 commits into from
May 27, 2020

Conversation

glitsj16
Copy link
Collaborator

No description provided.

@glitsj16 glitsj16 requested a review from rusty-snake May 27, 2020 17:13
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

etc/profile-m-z/mocp.profile Show resolved Hide resolved
Thanks to @rusty-snake for spotting this.
@glitsj16 glitsj16 merged commit b67e9a9 into netblue30:master May 27, 2020
@glitsj16 glitsj16 deleted the mocp branch May 27, 2020 17:42
@M1ndo
Copy link

M1ndo commented Feb 25, 2021

@glitsj16 there's an issue somewhere in the mocp profile config , when detaching from moc server (Using q) the window get stuck but the server still runs (like in the screenshot below) however if you sent a kill signal with (ctrl+c) the server shutdown and the music stops .
2021-02-25-122230_1078x367_scrot

@glitsj16
Copy link
Collaborator Author

@M1ndo Thanks for bringing this to our attention. For the moment though I'm having trouble reproducing it. But that's entirely due to my very hacked mocp setup. For starters I use a custom built moc PKGBUILD on Arch Linux instead of the official one from the AL repo's. I use Shift+Q to quit. To top it all off I decided to sandbox mocp with a whitelist profile. Together these changes work very nicely for me. I'll temporary revert of all my fiddlings and re-test the original profile without local overrides as soon as possible.

On a sidenote, there's this FAQ item upstream that might be helpful. Do you happen to have 'ShowTime = yes' and/or increased 'TagsCacheSize' in your ${HOME}/.config/moc/config?

@glitsj16
Copy link
Collaborator Author

@M1ndo Okay, here's some more info I've been able to gather. What you're seeing is indeed the behaviour I can reproduce with the Arch Linux repo package. Don't know what mocp is actually doing under the hood, but even with --noprofile detaching with 'q' does not stop the server. That's probably why I bound /usr/bin/mocp --exit to Shift+Q in the first place. Been too long ago to remember exactly. You could try this and if it proves to be a workable solution I'll add a note to the mocp.profile to that effect.

For this hack to work you need to use the full path to the unsandboxed mocp executable when binding the key you'd like to use. I'll need more time to investigate this and try to find a proper fix.

HTH

@M1ndo
Copy link

M1ndo commented Feb 28, 2021

Thanks replying back, In my config i set ShowTime To "no" And TagsCacheSize is unset however that's not the issue here .When detaching from mocp i don't wanna kill the moc server with (shift-q), i keep it running in the background while streaming music using (q) and that's where the window doesn't close (like in the screenshot i attached previously).
Using the full path to the unsandboxed mocp this doesn't happen at all .

@glitsj16
Copy link
Collaborator Author

I'm getting a 404 on that screenshot. But I think I understand now, 'mocp --exit' won't do in that cae. Alas, I can't provide a quick fix. What terminal app are you running mocp in? Is that sandboxed too?

@M1ndo
Copy link

M1ndo commented Feb 28, 2021

Here's the image LINK i'm using xterm unsandboxed.
Just in case i'm using jack2 and routing pulseaudio to jack , however this shouldn't cause the problem since mocp is using jack not pulse.

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Mar 1, 2021

I'm not able to fix this. There's a tip on the Arch Linux wiki to use Ctrl+z instead of 'q' to detach but for me that isn't working either. My advise at this stage is to open an issue on it and I'll mark it as a bug. At least that way should give it better visibility as other collaborators probably don't follow this conversation on a PR/merged page.

@M1ndo
Copy link

M1ndo commented Mar 2, 2021

@glitsj16 Sorry For The Delay , here's the issue i've opened Here discussing the problem with MOC and firejail .

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants