Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minecraft-launcher profile #3538

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Added minecraft-launcher profile #3538

merged 4 commits into from
Jul 27, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Jul 23, 2020

Request:# 1139

What to do with private-etc? In game multiplayer or realms doesn't work with it, tried with many combinations. Single player works fine with/without. Should be okay now.

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etc/profile-m-z/minecraft-launcher.profile Show resolved Hide resolved
etc/profile-m-z/minecraft-launcher.profile Show resolved Hide resolved
etc/profile-m-z/minecraft-launcher.profile Show resolved Hide resolved
Added space,tracelog,nodvd
@bbhtt bbhtt changed the title Added minecraft-launcher-profile Added minecraft-launcher profile Jul 23, 2020
private-bin minecraft-launcher,java,java-config
private-cache
private-dev
# private-etc alternatives,asound.conf,ca-certificates,crypto-policies,fonts,group,gtk-2.0,gtk-3.0,host.conf,hostname,hosts,ld.so.cache,ld.so.conf,ld.so.conf.d,ld.so.preload,localtime,machine-id,mime.types,nvidia,passwd,pki,pulse,resolv.conf,services,selinux,ssl,xdg,X11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if this line is uncommented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't connect to a server or Realms.

This should be resolved now can you please check,thanks,

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 24, 2020

I should whitelist /opt/minecraft-launcher since swiftshader cache is there and add a note because the executable on some Distros can reside on /opt/minecraft-launcher?

@rusty-snake
Copy link
Collaborator

Why? You has already private-opt minecraft-launcher.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 24, 2020

Adding a private-opt copies the entire subdirectory?

@rusty-snake
Copy link
Collaborator

Ahh you mean removing private-opt and using whitelist instead.

@rusty-snake
Copy link
Collaborator

anything left?

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

anything left?

Deciding on private-etc ,I guess. Are multiplayer known to cause problems with it: minetest,steam etc.?

@rusty-snake
Copy link
Collaborator

rusty-snake commented Jul 26, 2020

How do you created it? (Template, --build, --trace, strace, try & guess, strings, …)

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

I allowed the whole package of files from the template, still didn't work. I made it using the default private-etc that goes with an application with sound,video,3D,internet and depending on terminal spam+strace I add the rest like passwd. Maybe I'll try with strace.

@rusty-snake
Copy link
Collaborator

First try --build, much easier. The templates don't cover special things. In general: always check if there is a /etc/.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

Build gave private-etc resolv.conf,login.defs,openal,java-13-openjdk,drirc,timezone,fonts,xdg,gtk-3.0,machine-id,ssl,ati,hosts,selinux,passwd I have to check them now. Seems like it was login.defs or timezone.

@rusty-snake Thanks for the tip, I'll add them and ati,drirc,openal?

@rusty-snake
Copy link
Collaborator

I tend to java-13-openjdk, if so add it for more java versions.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

I tend to java-13-openjdk, if so add it for more java versions.

Nevermind, it was java, I removed the wrong group. How do I add more java versions? Like java-8-...,java-11-... etc. ? I use only OpenJDK, whereas people can use the one from Oracle package or the one that comes with the launcher, I don't know where the last is stored.

@rusty-snake
Copy link
Collaborator

Look at i2prouter, signal-cli, terasology. There is no realy good way now.

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

I'll add all the known ones of OpneJDK from 7-14. So a comment saying to comment this line in case breaks or add your own java folder?

Fixed private-etc,added notes about path,java
@rusty-snake
Copy link
Collaborator

The profile needs sorting (private-bin, private-etc).

@bbhtt
Copy link
Contributor Author

bbhtt commented Jul 26, 2020

Used the python script on it.

@rusty-snake
Copy link
Collaborator

+1 from me.

@rusty-snake rusty-snake merged commit 0430685 into netblue30:master Jul 27, 2020
@rusty-snake
Copy link
Collaborator

Merged, Thanks.

@bbhtt bbhtt deleted the minecraft-launcher branch July 27, 2020 08:26
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants