Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

really fix running kernel config check #3859

Merged
merged 2 commits into from
Dec 31, 2020
Merged

really fix running kernel config check #3859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
631d500
really fix running kernel config check
glitsj16 Dec 31, 2020
c0bb42e
really fix running kernel config check
glitsj16 Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions etc/profile-m-z/zcat.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ include zcat.local
#include globals.local

# Allow running kernel config check
noblacklist ${PATH}/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like that assumes that bash is the shell used with /bin/sh. shouldn't also other shells be allowed? because Debian uses dash as default shell for /bin/sh.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about Debian using dash. To cover all setups it's better to ignore including disable-shell.inc IMO. Thanks for catching this! A fix is waiting for the checks to finish.

noblacklist ${PATH}/sh
noblacklist /proc/config.gz

# Redirect
Expand Down
2 changes: 2 additions & 0 deletions etc/profile-m-z/zgrep.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ include zgrep.local
#include globals.local

# Allow running kernel config check
noblacklist ${PATH}/bash
noblacklist ${PATH}/sh
noblacklist /proc/config.gz

# Redirect
Expand Down