Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build with GCC 11 #4300

Merged
merged 1 commit into from
May 23, 2021
Merged

CI: build with GCC 11 #4300

merged 1 commit into from
May 23, 2021

Conversation

reinerh
Copy link
Collaborator

@reinerh reinerh commented May 23, 2021

this fixes a new false positive memory leak (#4297), but unfortunately
opens a few new false positives (#4274).
therefore let it ignore memleak checks for now, until the detection
is a bit more stable in GCC.

Fixes: #4274, #4297

ping @smitsohu @rusty-snake @glitsj16 @kmk3

@reinerh reinerh force-pushed the gcc11 branch 2 times, most recently from e96cdfb to 07b85f3 Compare May 23, 2021 09:48
this fixes a new false positive memory leak (#4297), but unfortunately
opens a few new false positives (#4274).
therefore let it ignore memleak checks for now, until the detection
is a bit more stable in GCC.

Fixes: #4274, #4297
@reinerh
Copy link
Collaborator Author

reinerh commented May 23, 2021

@smitsohu whitelist.exp test is now failing:

$ firejail --whitelist=~/fjtest-file-lnk --whitelist=~/fjtest-dir-lnk
Reading profile /etc/firejail/default.profile
Reading profile /etc/firejail/disable-common.inc
Reading profile /etc/firejail/disable-passwdmgr.inc
Reading profile /etc/firejail/disable-programs.inc

** Note: you can use --noprofile to disable default.profile **

Parent pid 19111, child pid 19112
Child process initialized in 70.08 ms
user@host:~$ TESTING ERROR 30

the test is doing the following:

# symlinks outside home to a file we don't own
send -- "rm ~/fjtest-file-lnk\r"
after 200
send -- "ln -s /etc/passwd ~/fjtest-file-lnk\r"
after 200
send -- "firejail --whitelist=~/fjtest-file-lnk --whitelist=~/fjtest-dir-lnk\r"
expect {
        timeout {puts "TESTING ERROR 30\n";exit}
        "invalid whitelist path"
}
expect {
        timeout {puts "TESTING ERROR 31\n";exit}
        "cannot sync with peer"
}
sleep 1

it expects that firejail throws an error, when a file is whitelisted that symlinks to outside home.
is this now considered allowed? or a bug in the whitelist?

@smitsohu
Copy link
Collaborator

@reinerh These symlink restrictions are gone, so we will need to disable the tests.

@smitsohu smitsohu merged commit d34bb19 into master May 23, 2021
@smitsohu
Copy link
Collaborator

I'll try to fix the broken tests in a separate pull request. Thanks!

smitsohu added a commit to smitsohu/firejail that referenced this pull request May 23, 2021
@reinerh reinerh deleted the gcc11 branch May 23, 2021 16:45
@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc -fanalyzer warnings (GCC 11)
2 participants