Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct amule.profile for upnp #4371

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

chrpinedo
Copy link
Contributor

In order UPnP to work netlink protocol must be added

Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since netlink opens a wide attack surface (to the kernel) it may be better to add it commented if UPnP is a rarely used feature of aMule.

@chrpinedo
Copy link
Contributor Author

I agree with you that one commented line could be interesting to other users.

@smitsohu
Copy link
Collaborator

smitsohu commented Oct 2, 2021

@chrpinedo Are you interested in adding a comment to the profile?

Otherwise I would suggest to merge as-is, in order to get the bug fixed.

In order UPnP to work netlink protocol must be enabled.
@chrpinedo
Copy link
Contributor Author

Since netlink protocol should be avoided when it is not required, I modified the commit to add one comment to the profile. If you agree, you could merge it.

@smitsohu
Copy link
Collaborator

smitsohu commented Oct 5, 2021

Merged!

@smitsohu smitsohu merged commit 32fb5ed into netblue30:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants