From f9620708e0f512a3264309fd49979d19c13e5fc6 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Fri, 17 Sep 2021 07:44:41 -0300 Subject: [PATCH 1/4] bug_report.md: use LC_ALL instead of LANG This overrides all `LC_*` variables (and LANG) rather than just LANG. From Section 8.2, Internationalization Variables of POSIX.1-2017[1]: > LANG > This variable shall determine the locale category for native > language, local customs, and coded character set in the absence of > the LC_ALL and other LC_* (LC_COLLATE, LC_CTYPE, LC_MESSAGES, > LC_MONETARY, LC_NUMERIC, LC_TIME) environment variables. This can > be used by applications to determine the language to use for error > messages and instructions, collating sequences, date formats, and > so on. > > LC_ALL > This variable shall determine the values for all locale > categories. The value of the LC_ALL environment variable has > precedence over any of the other environment variables starting > with LC_ (LC_COLLATE, LC_CTYPE, LC_MESSAGES, LC_MONETARY, > LC_NUMERIC, LC_TIME) and the LANG environment variable. [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 0f13afc51dd..dc5ebcee084 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -15,7 +15,7 @@ _Describe the bug_ _Steps to reproduce the behavior_ -1. Run in bash `LANG=C firejail PROGRAM` (`LANG=C` to get English messages that can be understood by everybody) +1. Run in bash `LC_ALL=C firejail PROGRAM` (`LC_ALL=C` to get a consistent output in English that can be understood by everybody) 2. Click on '....' 3. Scroll down to '....' 4. See error `ERROR` From 2b2df6604773f6c5a424456f43bb8200c6d33ab2 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Fri, 17 Sep 2021 07:46:01 -0300 Subject: [PATCH 2/4] bug_report.md: use LC_ALL where appropriate --- .github/ISSUE_TEMPLATE/bug_report.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index dc5ebcee084..dd7c4b22004 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -30,7 +30,7 @@ _What actually happened_ ### Behavior without a profile -_What changed calling `firejail --noprofile /path/to/program` in a terminal?_ +_What changed calling `LC_ALL=C firejail --noprofile /path/to/program` in a terminal?_ ### Additional context @@ -55,7 +55,7 @@ _Any other detail that may help to understand/debug the problem_ ### Log
-Output of firejail /path/to/program +Output of LC_ALL=C firejail /path/to/program

``` @@ -66,7 +66,7 @@ output goes here

-Output of firejail --debug /path/to/program +Output of LC_ALL=C firejail --debug /path/to/program

``` From b39ef34e0a9b17b736dacf1e6f7e6a1799a83c82 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Sat, 18 Sep 2021 06:14:51 -0300 Subject: [PATCH 3/4] bug_report.md: add checked item example It is not uncommon for people to use other characters to try to mark an item as checked (which usually screws up the html output), so be sure to include an example with "[x]". --- .github/ISSUE_TEMPLATE/bug_report.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index dd7c4b22004..14d887e8b5e 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -44,6 +44,12 @@ _Any other detail that may help to understand/debug the problem_ ### Checklist + + - [ ] The issues is caused by firejail (i.e. running the program by path (e.g. `/usr/bin/vlc`) "fixes" it). - [ ] I can reproduce the issue without custom modifications (e.g. globals.local). - [ ] The program has a profile. (If not, request one in `https://github.com/netblue30/firejail/issues/1139`) From 20727361b203f38bf9534a96e65957733bc6ebf1 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Mon, 20 Sep 2021 08:22:12 -0300 Subject: [PATCH 4/4] bug_report.md: link to markdown formatting help As suggested by @rusty-snake. --- .github/ISSUE_TEMPLATE/bug_report.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 14d887e8b5e..eb485b8a2a8 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -7,6 +7,13 @@ assignees: '' --- + + ### Description _Describe the bug_