netbox 3.6 support

[ryanmerolle]

Pull Request

Related Issue

#159

New Behavior

Development:

• devcontainer bumped to NetBox 3.6
• migrate from vscode user given ubtuntu uid conflicts

NetBox Changes to investigate

• The device_role field on the Device model has been renamed to role. The device_role field has been temporarily retained on the REST API serializer for devices for backward compatibility, but is read-only.
• The choices array field has been removed from the CustomField model. Any defined choices are automatically migrated to CustomFieldChoiceSets, accessible via the new choice_set field on the CustomField model.
• Introduce choice sets for custom fields netbox#12988 -Custom Field Choice Sets
• Remove the custom ChoiceField and MultipleChoiceField subclasses netbox#11766 - Remove obsolete custom ChoiceField and MultipleChoiceField classes
• The device_role field on the Device model has been renamed to role. The device_role field has been temporarily retained on the REST API serializer for devices for backward compatibility, but is read-only.

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

• I have explained my PR according to the information in the comments
  or in a linked issue.
• My PR targets the dev branch.

[ryanmerolle]

@Cormoran96 @abhi1693 @jsenecal tagging for visibility.

I started looking at change for 3.6. Development in VS Code devcontainer now works, but all views except for ACL Interface Assignments are broken.

I'm not currently leveraging NetBox at my new job, but that will likely eventually change. Just explaining why this work is not already done.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[garnser]

Tested, works for 3.7 as well

[abhi1693]

If my suggestion is not required, let's release these changes

[sonarcloud]

Quality Gate failed

Failed conditions

2 Security Hotspots

See analysis details on SonarCloud

[jeffgdotorg]

@abhi1693 @ryanmerolle between this PR and @kbelokon's draft PR #175, I think we have all the pieces to get this plugin working through NetBox 3.7. How do we break the logjam?

Let me know if you need me to remove any obstacles. The two hotspots identified by Sonar look okay to me; if you concur, and if the checks all pass after marking them safe, I'm a +1 to merging once the 3.7 changes are in.

PS I tested the fix branch for #175 in a 3.7.4 system and it did not blow up in my face.