Feat/add fields site and redistribute policy #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 31, 2025 14:41
Add filter for site field Add site to graphql Fix type Fix type Fix errors Add site filter Add site filter
# Conflicts: # netbox_bgp/models.py
Fix template for session and redistributing in device page Fix template for session and redistributing in device page Fix errors and refactoring Fix and refactoring fix and refactoring
Author
|
Hey, any updates? |
Member
|
hey @nazarko-es there seems to be 2 changes here covered by 1 PR - in future please split these into 1 change per PR (ie: site + redistribution = 2 PRs). In terms of site, would you not instead scope this ? ie: to allow region, site, location etc as per other models ? |
Author
|
hey, in future i will split. About site i didn't think about use scope because it isn't relevant in my target. I can change it to scope |
…add-fields-site-and-redistribute-policy # Conflicts: # netbox_bgp/api/serializers.py # netbox_bgp/forms.py # netbox_bgp/graphql/types.py # netbox_bgp/models.py # netbox_bgp/tables.py # netbox_bgp/template_content.py # netbox_bgp/templates/netbox_bgp/device_extend.html # netbox_bgp/templates/netbox_bgp/routingpolicy.html
Collaborator
|
i need some time to review |
Author
|
hi, i merged updates from source branch and changed site to scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "site" field in ASPathList, CommunityList, RoutePolicy, PrefixList - it's usefull if you reuse names of this objects in diffrent sites but with diffrent rules. If the site is None, uniquiness of name is checking as before.
Also i added new object "redistributing". It provides to add redistributing of routes from other routing protocols with policy