Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postgres Docker tag to v14 #594

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 30, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Update Change
postgres major 13-alpine -> 14-alpine

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Sep 30, 2021
@kkthxbye-code
Copy link

For reference EoL of postgres v13 is November 13, 2025, v14 was released yesterday and netbox currently requires v9.6, soon v10 in netbox 3.1.

While it doesn't really matter, because I assume most people pin their postgres version in docker-compose, I don't think it is worth it to change the default, as there will certainly be tickets again regarding the postgres container not starting after a docker-compose pull.

@cimnine
Copy link
Collaborator

cimnine commented Oct 5, 2021

as there will certainly be tickets again regarding the postgres container not starting after a docker-compose pull.

This is true. But IMO it doesn't really matter, since we'll just have the tickets when they will finally have to upgrade. When we upgrade regularly, at least the users that start out with the latest PostgreSQL version will have the most time to stick to the PostgreSQL version which they started with. Plus they learn to read the release notes early on ;-)

So if a user today starts with PostgreSQL 14, that user will likely have 5 years until an upgrade is needed.

@renovate renovate bot force-pushed the renovate/postgres-14.x branch 2 times, most recently from 6957e60 to b2fa1ee Compare October 5, 2021 08:58
@cimnine cimnine enabled auto-merge October 5, 2021 09:11
@cimnine cimnine disabled auto-merge October 5, 2021 09:25
@cimnine
Copy link
Collaborator

cimnine commented Oct 5, 2021

This change should only be included in a minor update, not in a patch update.

@renovate renovate bot force-pushed the renovate/postgres-14.x branch 4 times, most recently from bab902d to 28a4c18 Compare October 11, 2021 20:39
@renovate renovate bot force-pushed the renovate/postgres-14.x branch 2 times, most recently from d1d3093 to 57c83e4 Compare October 14, 2021 14:46
@cimnine cimnine merged commit 6c49d4f into develop Oct 19, 2021
@cimnine cimnine deleted the renovate/postgres-14.x branch October 19, 2021 15:30
@tobiasge tobiasge mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants