Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ENV variables for INSECURE_SKIP_TLS_VERIFY #630

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Added ENV variables for INSECURE_SKIP_TLS_VERIFY #630

merged 1 commit into from
Oct 20, 2021

Conversation

tobiasge
Copy link
Member

Related Issue: #580

New Behavior

  • Read value for INSECURE_SKIP_TLS_VERIFY (Redis) from ENV variables

Contrast to Current Behavior

  • INSECURE_SKIP_TLS_VERIFY can't be set from ENV variables

Discussion: Benefits and Drawbacks

  • Default is the same as it was, so there shouldn't be side effects

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Read value for INSECURE_SKIP_TLS_VERIFY (Redis) from ENV variables

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine cimnine added the enhancement The issue describes an enhancement that we would like to implement in the future. label Oct 20, 2021
@tobiasge tobiasge merged commit a206ad6 into netbox-community:develop Oct 20, 2021
@tobiasge tobiasge deleted the fix-580 branch October 20, 2021 07:49
@tobiasge tobiasge mentioned this pull request Oct 20, 2021
Closed
@tobiasge tobiasge mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
enhancement The issue describes an enhancement that we would like to implement in the future.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine