Startup scripts typos #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the PR target to the |
tobiasge
force-pushed
the
startup_scripts_typos
branch
from
cfa0579
to
a7e28de
Compare
- group creation prints proper group name - permission creation prints proper permission name
tobiasge
force-pushed
the
startup_scripts_typos
branch
from
a7e28de
to
ce8db10
Compare
tobiasge
approved these changes
Oct 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
Print proper group name when creating new groups via startup_script.
Print proper permission name when assigning permissions to a user or group.
Contrast to Current Behavior
Creating a group did print the reference to an
AdminGroup.nameobject.Creating permission objects did print the name of the group when assigning the permission to groups.
Creating permission objects did print the name of the group when assigning the permission to users.
Discussion: Benefits and Drawbacks
Changes to the Wiki
Proposed Release Note Entry
Double Check
developbranch.