Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __dir__ to configuration file #656

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

tobiasge
Copy link
Member

Related Issue: #653

New Behavior

  • All configuration values from all imported files are listed and can be used from Netbox

Contrast to Current Behavior

  • New SOCIAL_AUTH_* parameters are ignored

Discussion: Benefits and Drawbacks

It is now possible to set all configuration values from extra files.

Changes to the Wiki

  • None

Proposed Release Note Entry

  • New SOCIAL_AUTH_* parameters can be configured from extra config files

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how it works, but it's been a while since I wrote that configuration magic. I've also seen the comment in the issue and trust you, that it does (just) the right thing 👍

@tobiasge
Copy link
Member Author

Alpine edge checks can be ignored as we are switching to Debian soon (I hope).

@tobiasge tobiasge merged commit 4b7037b into netbox-community:develop Nov 30, 2021
@tobiasge tobiasge deleted the fix-653 branch November 30, 2021 10:50
@tobiasge tobiasge mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants