Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed release action workflow #658

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fixed release action workflow #658

merged 1 commit into from
Dec 9, 2021

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Dec 9, 2021

Related Issue:

New Behavior

  • Release is build and pushed

Contrast to Current Behavior

  • Strange error in build.sh

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Quick fix for Github Action workflow

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine December 9, 2021 10:25
cimnine
cimnine approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to revisit this when we want to do ARM builds, as we will then depend on Buildx and QEMU.

@tobiasge tobiasge merged commit 2e92554 into netbox-community:develop Dec 9, 2021
@tobiasge tobiasge mentioned this pull request Dec 9, 2021
Merged
@tobiasge tobiasge deleted the fix-action branch June 10, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine