Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk update data type is incorrect in swagger spec #10922

Closed
abhi1693 opened this issue Nov 15, 2022 · 3 comments
Closed

Bulk update data type is incorrect in swagger spec #10922

abhi1693 opened this issue Nov 15, 2022 · 3 comments
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@abhi1693
Copy link
Member

NetBox version

v3.3.7

Python version

3.10

Steps to Reproduce

As per the swagger doc, the bulk payload requires a dict
image

However, when trying to run the same, it throws an error

image

The issue is seen for all models in the spec for PUT and PATCH using the bulk operations

Expected Behavior

The spec should display that the required payload should be a List of items/dictionaries

Observed Behavior

The spec displays it needs a dictionary
@abhi1693 abhi1693 added the type: bug A confirmed report of unexpected behavior in the application label Nov 15, 2022
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Nov 18, 2022
@abhi1693
Copy link
Member Author

abhi1693 commented Jan 12, 2023 •
edited
Loading

@jeremystretch @arthanson @kkthxbye-code I'd like to take this

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 12, 2023
@jeremystretch
Copy link
Member

Thanks @abhi1693!

@abhi1693 abhi1693 mentioned this issue Jan 12, 2023
Closed
@jeremystretch
Copy link
Member

We discovered during review of PR #11481 that resolving this adequately will likely require a significant amount of further work. Given the upcoming release of NetBox v3.5, which replaces the current schema with OpenAPI 3.0 (see #9608), we're going to abandon this change.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed swagger schema for bulk operation
2 participants
@abhi1693 @jeremystretch