Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove add button if not needed. #12848

Closed
Gabrielsc opened this issue Jun 9, 2023 · 5 comments
Closed

remove add button if not needed. #12848

Gabrielsc opened this issue Jun 9, 2023 · 5 comments
Labels
status: revisions needed This issue requires additional information to be actionable type: feature Introduction of new functionality to the application

Comments

@Gabrielsc
Copy link

NetBox version

v3.5.3

Feature type

Change to existing functionality

Proposed functionality

Since the add button is not suitable to be on the virtualization -> interfaces page as mentioned by @abhi1693 in #12847 , I propose to remove the add button in the image below.
image

Stay like on other pages that don't need the add button.
image

Use case

simplify usability.

Database changes

No response

External dependencies

No response

@Gabrielsc Gabrielsc added the type: feature Introduction of new functionality to the application label Jun 9, 2023
@arthanson
Copy link
Collaborator

@sudheesh001 did you want to work on this one?

@sudheesh001
Copy link
Contributor

Yes please, thank you so much! I'll take a shot at this as a part of the hackathon

@kkthxbye-code
Copy link
Contributor

kkthxbye-code commented Jun 11, 2023

I'm sorry how does this FR make sense? The button was just recently added?

Edit:

Here's where they were added, why would we accept a FR to remove them again? Doesn't seem to make sense.

#11968

I also see no reason why this was closed: #12847

@abhi1693 - why did you close that? It seems inconsistent with the rest of the views and as such valid from my perspective.

@kkthxbye-code kkthxbye-code added the status: revisions needed This issue requires additional information to be actionable label Jun 11, 2023
@arthanson
Copy link
Collaborator

@kkthxbye-code yes, look like these are reversed, this should be closed and #12847 should be opened / fixed.

@arthanson
Copy link
Collaborator

Closing this as the real issue should be fixed in #12847

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: revisions needed This issue requires additional information to be actionable type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants