You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#4262 introduced support for an optional commit argument in a custom script's run() method. This issue serves to document the deprecation of this as an optional argument: Beginning with v2.10, a custom script's run() method must accept a commit argument.
Justification
Removes superfluous backward-compatibility logic from core. A custom script doesn't necessarily need to do anything with the commit argument; it just needs to accept it when called via run_script().
The text was updated successfully, but these errors were encountered:
Proposed Changes
#4262 introduced support for an optional
commit
argument in a custom script'srun()
method. This issue serves to document the deprecation of this as an optional argument: Beginning with v2.10, a custom script'srun()
method must accept acommit
argument.Justification
Removes superfluous backward-compatibility logic from core. A custom script doesn't necessarily need to do anything with the
commit
argument; it just needs to accept it when called viarun_script()
.The text was updated successfully, but these errors were encountered: