Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a get_utilization() method on the RIR model #4961

Closed
jeremystretch opened this issue Aug 6, 2020 · 1 comment
Closed

Create a get_utilization() method on the RIR model #4961

jeremystretch opened this issue Aug 6, 2020 · 1 comment
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Create a get_utilization() method on the RIR model to return the total utilization of all assigned aggregates, similar to what exists on the Prefix model.

Justification

RIR utilization is currently calculated by manipulating the queryset used in the list view. This is both inefficient and inflexible, because no convenient method exists for determining the utilization of a particular RIR. Moving this logic into a method is cleaner and allows us to remove the alter_queryset() method on ObjectListView.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user beta Concerns a bug/feature in a beta release labels Aug 6, 2020
@jeremystretch jeremystretch self-assigned this Aug 6, 2020
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed beta Concerns a bug/feature in a beta release status: accepted This issue has been accepted for implementation labels Aug 6, 2020
@jeremystretch jeremystretch removed their assignment Aug 6, 2020
@jeremystretch jeremystretch added status: blocked Another issue or external requirement is preventing implementation status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation status: blocked Another issue or external requirement is preventing implementation labels Aug 6, 2020
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Sep 15, 2020
@jeremystretch jeremystretch self-assigned this Sep 15, 2020
@jeremystretch
Copy link
Member Author

Assigning myself to further investigate the feasibility of this. If found to be more trouble than it's likely worth, I'll open a separate issue to deprecate the RIR statistics feature entirely.

@jeremystretch jeremystretch removed the status: accepted This issue has been accepted for implementation label Sep 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

1 participant