Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit termination port speed should be optional #5225

Closed
jeremystretch opened this issue Oct 8, 2020 · 0 comments
Closed

Circuit termination port speed should be optional #5225

jeremystretch opened this issue Oct 8, 2020 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.10

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Make the port_speed field on the CircuitTermination model optional.

Justification

This field is mostly a relic of very early NetBox development. Although still useful, it should not be mandatory. (Frankly, I'm surprised this suggestion hasn't yet been raised.)
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: under review Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping Changes to the application which do not directly impact the end user and removed type: feature Introduction of new functionality to the application labels Oct 8, 2020
@jeremystretch jeremystretch self-assigned this Oct 9, 2020
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Oct 9, 2020
@jeremystretch jeremystretch added this to the v2.10 milestone Oct 9, 2020
jeremystretch added a commit that referenced this issue Oct 9, 2020
@jeremystretch
Closes #5225: CircuitTermination port_speed is now optional
30778a9
@jeremystretch jeremystretch mentioned this issue Dec 14, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v2.10
Development

No branches or pull requests
1 participant
@jeremystretch