Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation Updates (Migrate from drf-yasg -> drf-spectacular) #9608

Closed
huntabyte opened this issue Jun 27, 2022 · 4 comments
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@huntabyte
Copy link
Contributor

Proposed Changes

I would like to work on updating the API documentation, however, the current package used to generate and manage the swagger docs lacks functionality, doesn't support OpenAPI 3.0, and isn't being actively maintained.

drf-spectacular is being actively maintained and provides some of the missing functionality.

I'd like to work on making this happen.

Justification

This would improve the developer's experience when building applications that interact with NetBox.

@huntabyte huntabyte added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 27, 2022
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jul 27, 2022
@arthanson arthanson added the needs milestone Awaiting prioritization for inclusion with a future NetBox release label Sep 15, 2022
@arthanson
Copy link
Collaborator

@huntabyte are you still available and wanting to work on this?

@huntabyte
Copy link
Contributor Author

@arthanson Yes, for sure.

@arthanson
Copy link
Collaborator

@huntabyte That is great - thank you. Please go ahead and start working on this in a new branch. It will probably be tough to fit it into 3.4 release, probably would be 3.5 but we can see.

If possible, it probably makes sense to keep the current OpenAPI 2.0 drf-yasg in and have the drf-spectacular OpenAPI 3.0 in parallel, but I'm not sure if that is possible? If you need any help on it or questions, please let me know.

@jeremystretch jeremystretch removed the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Sep 16, 2022
@arthanson
Copy link
Collaborator

@huntabyte any progress on this so far? I saw a couple other issues that OpenAPI 3 would be nice for.

@arthanson arthanson self-assigned this Nov 2, 2022
@arthanson arthanson removed their assignment Dec 2, 2022
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed needs milestone Awaiting prioritization for inclusion with a future NetBox release labels Jan 5, 2023
@jeremystretch jeremystretch added this to the v3.5 milestone Jan 5, 2023
@arthanson arthanson self-assigned this Jan 6, 2023
jeremystretch added a commit that referenced this issue Mar 30, 2023
Co-authored-by: arthanson <worldnomad@gmail.com>
Co-authored-by: jeremystretch <jstretch@netboxlabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

3 participants