Closes #8248: User bookmarks #13035
Merged
Closes #8248: User bookmarks #13035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Documentation?
Also - not sure necessary as you have filtering on the widget, but it might be nice to group them by type with header for the dashboard widget:
Devices
PP:B117
PP:B118
IP addresses
172.16.0.1/24
The profile page shows the type but nothing on the widget which can make it confusing.
|
My intent currently is to keep the widget content minimal, but I'm happy to revisit denoting object types if we get more feedback about it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8248
extras.Bookmarkmodel and relevant views to enable the creation and removal of bookmarks