Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Design Icons #2776

Closed
wants to merge 1 commit into from
Closed

Material Design Icons #2776

wants to merge 1 commit into from

Conversation

MarcHagen
Copy link
Contributor

Fixes: #2755

Changed all font awesome icons and glyphicon to MDI, as close as possible.
There had been some small style changes to make it fit and look better.

As of pushing the latest version of MDI is/was 3.3.92

Fix not aligned buttons, small style changes
@jeremystretch
Copy link
Member

While I appreciate the effort, there's a lot of questionable content here, the custom CSS you've added in particular. For example:

.mdi.mdi-magnify::before,
.mdi.mdi-close::before,
.mdi.mdi-plus::before {
    font-weight: bold;
}

Adding styling for specific icons isn't maintainable. There are also some strange rules, such as:

.mdi.mdi-fw::before {
    width: 1.2857142857142858em;
    text-align: center;
}

Further, it looks like you've included many unnecessary files from the MDI library, and omitted the version number. Ultimately it's not very practical to review a pull request with 108 changed files, even if most of them are icon name substitutions.

@MarcHagen
Copy link
Contributor Author

Hi there,
So personally I’m never changing vendor content. Therefore I had added just the package as it is. A version number could be added to the directory name.

The icon specific formatting was just a style thing and could be removed if wished.

The ‘.mdi.mdi-fw’ is nowhere strange it exactly the same as font awesome.

For me the question is now, do you want me to change the requested changes or are you going to do it yourself, then just close this PR.

@jeremystretch
Copy link
Member

Thank you again for the effort, but I'd like to take this on myself, and work on making icons and other UI elements more consistent overall. This will likely result in a large number of frontend tweaks spanning several releases.

@MarcHagen MarcHagen deleted the feature/materialdesignicons branch January 17, 2019 16:53
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Material Design icons
2 participants