From b8b2ea7ccbe9b1132f6a22c143548d99d966e6d4 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Thu, 26 Jan 2017 14:00:08 -0500
Subject: [PATCH 01/10] Post-release version bump

---
 netbox/netbox/settings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index d5909a96085..f5d7df4d4fd 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -12,7 +12,7 @@
                                "the documentation.")
 
 
-VERSION = '1.8.3'
+VERSION = '1.8.4-dev'
 
 # Import local configuration
 for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY']:

From af3c9eaec17af2e6ca6993d950bfdb451ce95f04 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Mon, 30 Jan 2017 12:13:24 -0500
Subject: [PATCH 02/10] Fixes #854: Correct processing of get_return_url() in
 ObjectDeleteView

---
 netbox/utilities/views.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netbox/utilities/views.py b/netbox/utilities/views.py
index 2fd8123b016..fb5943dc04c 100644
--- a/netbox/utilities/views.py
+++ b/netbox/utilities/views.py
@@ -267,7 +267,7 @@ def post(self, request, **kwargs):
             if return_url and is_safe_url(url=return_url, host=request.get_host()):
                 return redirect(return_url)
             else:
-                return redirect(self.default_return_url)
+                return redirect(self.get_return_url(obj))
 
         return render(request, self.template_name, {
             'obj': obj,

From f4f41a5985557f526af5819250b1c47ee28ccdfa Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Tue, 31 Jan 2017 09:41:25 -0500
Subject: [PATCH 03/10] Fixes #859: Fix Javascript for connection status toggle
 button

---
 netbox/templates/dcim/device.html | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/netbox/templates/dcim/device.html b/netbox/templates/dcim/device.html
index 0ce898e01ac..4507e21411c 100644
--- a/netbox/templates/dcim/device.html
+++ b/netbox/templates/dcim/device.html
@@ -548,9 +548,10 @@
 {% block javascript %}
 <script type="text/javascript">
 function toggleConnection(elem, api_url) {
+    var url = netbox_api_path + api_url + elem.attr('data') + "/";
     if (elem.hasClass('connected')) {
         $.ajax({
-            url: netbox_api_path + api_url + elem.attr('data') + "/",
+            url: url,
             method: 'PATCH',
             dataType: 'json',
             beforeSend: function(xhr, settings) {
@@ -569,7 +570,7 @@
         });
     } else {
         $.ajax({
-            url: api_url + elem.attr('data') + "/",
+            url: url,
             method: 'PATCH',
             dataType: 'json',
             beforeSend: function(xhr, settings) {

From 8536f6c163b717a6a8a4cc9bba457c48e89975d2 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Tue, 31 Jan 2017 16:54:13 -0500
Subject: [PATCH 04/10] Closes #856: Strip whitespace from fields during CSV
 import

---
 netbox/utilities/forms.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/netbox/utilities/forms.py b/netbox/utilities/forms.py
index 5a881438181..73d0825253d 100644
--- a/netbox/utilities/forms.py
+++ b/netbox/utilities/forms.py
@@ -252,6 +252,7 @@ def to_python(self, value):
                 elif len(row) > len(self.columns):
                     raise forms.ValidationError("Line {}: Too many fields (found {}; expected {})"
                                                 .format(i, len(row), len(self.columns)))
+                row = [col.strip() for col in row]
                 record = dict(zip(self.columns, row))
                 records.append(record)
         return records

From b370375414330ed810c71bfeda03145bcaa30c95 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Tue, 31 Jan 2017 17:25:44 -0500
Subject: [PATCH 05/10] Fixes #861: Avoid overwriting device primary IP
 assignment from alternate family during bulk import of IP addresses

---
 netbox/ipam/views.py | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/netbox/ipam/views.py b/netbox/ipam/views.py
index 38c641e055e..f93f297e039 100644
--- a/netbox/ipam/views.py
+++ b/netbox/ipam/views.py
@@ -635,16 +635,14 @@ class IPAddressBulkImportView(PermissionRequiredMixin, BulkImportView):
 
     def save_obj(self, obj):
         obj.save()
-        # Update primary IP for device if needed
+
+        # Update primary IP for device if needed. The Device must be updated directly in the database; otherwise we risk
+        # overwriting a previous IP assignment from the same import (see #861).
         try:
             if obj.family == 4 and obj.primary_ip4_for:
-                device = obj.primary_ip4_for
-                device.primary_ip4 = obj
-                device.save()
+                Device.objects.filter(pk=obj.primary_ip4_for.pk).update(primary_ip4=obj)
             elif obj.family == 6 and obj.primary_ip6_for:
-                device = obj.primary_ip6_for
-                device.primary_ip6 = obj
-                device.save()
+                Device.objects.filter(pk=obj.primary_ip6_for.pk).update(primary_ip6=obj)
         except Device.DoesNotExist:
             pass
 

From 5eb3c1a67b282af49e34e42495143d46685c059c Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Wed, 1 Feb 2017 10:48:36 -0500
Subject: [PATCH 06/10] Removed deprecated base_path Swagger setting

---
 netbox/netbox/settings.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index f5d7df4d4fd..f316c03fb35 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -189,11 +189,6 @@
 if LOGIN_REQUIRED:
     REST_FRAMEWORK['DEFAULT_PERMISSION_CLASSES'] = ('rest_framework.permissions.IsAuthenticated',)
 
-# Swagger settings (API docs)
-SWAGGER_SETTINGS = {
-    'base_path': '{}/{}api/docs'.format(ALLOWED_HOSTS[0], BASE_PATH),
-}
-
 # Django debug toolbar
 INTERNAL_IPS = (
     '127.0.0.1',

From 0eba5a0de3cf12df35322a50f7bef628121be55c Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Wed, 1 Feb 2017 11:49:54 -0500
Subject: [PATCH 07/10] Fixes #851: Resolve encoding issues during
 import/export with Python 3

---
 netbox/utilities/forms.py | 13 +++++++------
 netbox/utilities/utils.py | 25 ++++++++++++++++++-------
 2 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/netbox/utilities/forms.py b/netbox/utilities/forms.py
index 73d0825253d..f6e0b36b1c9 100644
--- a/netbox/utilities/forms.py
+++ b/netbox/utilities/forms.py
@@ -236,14 +236,15 @@ def __init__(self, csv_form, *args, **kwargs):
         if not self.help_text:
             self.help_text = 'Enter one line per record in CSV format.'
 
-    def utf_8_encoder(self, unicode_csv_data):
-        for line in unicode_csv_data:
-            yield line.encode('utf-8')
-
     def to_python(self, value):
-        # Return a list of dictionaries, each representing an individual record
+        """
+        Return a list of dictionaries, each representing an individual record
+        """
+        # Python 2's csv module has problems with Unicode
+        if not isinstance(value, str):
+            value = value.encode('utf-8')
         records = []
-        reader = csv.reader(self.utf_8_encoder(value.splitlines()))
+        reader = csv.reader(value.splitlines())
         for i, row in enumerate(reader, start=1):
             if row:
                 if len(row) < len(self.columns):
diff --git a/netbox/utilities/utils.py b/netbox/utilities/utils.py
index 7002cafc034..8aaded4104d 100644
--- a/netbox/utilities/utils.py
+++ b/netbox/utilities/utils.py
@@ -1,15 +1,26 @@
+import six
+
+
 def csv_format(data):
     """
     Encapsulate any data which contains a comma within double quotes.
     """
     csv = []
-    for d in data:
-        if d in [None, False]:
+    for value in data:
+
+        # Represent None or False with empty string
+        if value in [None, False]:
             csv.append(u'')
-        elif type(d) not in (str, unicode):
-            csv.append(u'{}'.format(d))
-        elif u',' in d:
-            csv.append(u'"{}"'.format(d))
+            continue
+
+        # Force conversion to string first so we can check for any commas
+        if not isinstance(value, six.string_types):
+            value = u'{}'.format(value)
+
+        # Double-quote the value if it contains a comma
+        if u',' in value:
+            csv.append(u'"{}"'.format(value))
         else:
-            csv.append(d)
+            csv.append(u'{}'.format(value))
+
     return u','.join(csv)

From 9905099a71f77ca591cf942adc3fc32014194e3b Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Wed, 1 Feb 2017 11:59:47 -0500
Subject: [PATCH 08/10] Fixes #854: Check whether object still exists before
 attempting to resolve its URL

---
 netbox/utilities/views.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netbox/utilities/views.py b/netbox/utilities/views.py
index fb5943dc04c..315298383b2 100644
--- a/netbox/utilities/views.py
+++ b/netbox/utilities/views.py
@@ -228,7 +228,7 @@ def get_object(self, kwargs):
             return get_object_or_404(self.model, pk=kwargs['pk'])
 
     def get_return_url(self, obj):
-        if hasattr(obj, 'get_absolute_url'):
+        if obj.pk and hasattr(obj, 'get_absolute_url'):
             return obj.get_absolute_url()
         return reverse(self.default_return_url)
 

From d817990283ee550dd5b4a935b701be5e5e701f42 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Wed, 1 Feb 2017 12:09:59 -0500
Subject: [PATCH 09/10] Fixes #865: Fix server error when attempting to delete
 a protected object parent (Python 3)

---
 netbox/utilities/error_handlers.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/netbox/utilities/error_handlers.py b/netbox/utilities/error_handlers.py
index e456b8fb2c0..1691b41cdb3 100644
--- a/netbox/utilities/error_handlers.py
+++ b/netbox/utilities/error_handlers.py
@@ -5,20 +5,19 @@ def handle_protectederror(obj, request, e):
     """
     Generate a user-friendly error message in response to a ProtectedError exception.
     """
-    dependent_objects = e[1]
     try:
-        dep_class = dependent_objects[0]._meta.verbose_name_plural
+        dep_class = e.protected_objects[0]._meta.verbose_name_plural
     except IndexError:
         raise e
 
     # Grammar for single versus multiple triggering objects
     if type(obj) in (list, tuple):
-        err_message = "Unable to delete the requested {}. The following dependent {} were found: ".format(
+        err_message = u"Unable to delete the requested {}. The following dependent {} were found: ".format(
             obj[0]._meta.verbose_name_plural,
             dep_class,
         )
     else:
-        err_message = "Unable to delete {} {}. The following dependent {} were found: ".format(
+        err_message = u"Unable to delete {} {}. The following dependent {} were found: ".format(
             obj._meta.verbose_name,
             obj,
             dep_class,
@@ -26,11 +25,11 @@ def handle_protectederror(obj, request, e):
 
     # Append dependent objects to error message
     dependent_objects = []
-    for o in e[1]:
+    for o in e.protected_objects:
         if hasattr(o, 'get_absolute_url'):
-            dependent_objects.append('<a href="{}">{}</a>'.format(o.get_absolute_url(), str(o)))
+            dependent_objects.append(u'<a href="{}">{}</a>'.format(o.get_absolute_url(), o))
         else:
             dependent_objects.append(str(o))
-    err_message += ', '.join(dependent_objects)
+    err_message += u', '.join(dependent_objects)
 
     messages.error(request, err_message)

From 585e08eb9579c1c1ba52e7ca9bf033f1047ff346 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@digitalocean.com>
Date: Fri, 3 Feb 2017 13:55:32 -0500
Subject: [PATCH 10/10] Release v1.8.4

---
 netbox/netbox/settings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index f316c03fb35..7eb8e04a2fb 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -12,7 +12,7 @@
                                "the documentation.")
 
 
-VERSION = '1.8.4-dev'
+VERSION = '1.8.4'
 
 # Import local configuration
 for setting in ['ALLOWED_HOSTS', 'DATABASE', 'SECRET_KEY']: