cleanup

Author: arthanson

netbox_custom_objects/migrations/0002_ensure_fk_constraints.py

@@ -1,30 +1,19 @@
-# Generated migration to ensure FK constraints for existing OBJECT fields
-
 from django.db import migrations
 
 
 def ensure_existing_fk_constraints(apps, schema_editor):
     """
     Go through all existing CustomObjectType models and ensure FK constraints
     are properly set for any OBJECT type fields.
-
-    This is needed because the _ensure_fk_constraints method was refactored to work
-    on individual fields rather than all fields, and this migration ensures existing
-    fields have proper CASCADE constraints.
     """
     # Import the actual model class (not the historical version) to access methods
     from netbox_custom_objects.models import CustomObjectType
 
     for custom_object_type in CustomObjectType.objects.all():
         try:
-            # Get the dynamically generated model for this CustomObjectType
             model = custom_object_type.get_model()
-
-            # Use the _ensure_all_fk_constraints method which processes all OBJECT fields
-            # This method is kept specifically for migration purposes
             custom_object_type._ensure_all_fk_constraints(model)
         except Exception as e:
-            # Log but don't fail the migration if a specific type has issues
             print(f"Warning: Could not ensure FK constraints for {custom_object_type}: {e}")
 
 

netbox_custom_objects/models.py

@@ -602,9 +602,6 @@ def _ensure_all_fk_constraints(self, model):
         Ensure that foreign key constraints are properly created at the database level
         for ALL OBJECT type fields with ON DELETE CASCADE.
 
-        NOTE: This method is deprecated for normal use - use _ensure_field_fk_constraint
-        for individual fields. This is kept for migration purposes only.
-
         :param model: The model to ensure FK constraints for
         """
         # Query all OBJECT type fields for this CustomObjectType
@@ -1558,14 +1555,9 @@ def save(self, *args, **kwargs):
                     schema_editor.alter_field(model, old_field, model_field)
 
         # Ensure FK constraints are properly created for OBJECT fields with CASCADE behavior
-        # Only do this when:
-        # 1. Creating a new OBJECT field, OR
-        # 2. Updating an existing field where type changed to OBJECT, OR
-        # 3. Updating an existing OBJECT field where related_object_type changed
         should_ensure_fk = False
         if self.type == CustomFieldTypeChoices.TYPE_OBJECT:
             if self._state.adding:
-                # New OBJECT field - ensure FK constraint
                 should_ensure_fk = True
             else:
                 # Existing field - check if type changed to OBJECT or related_object_type changed
@@ -1585,7 +1577,6 @@ def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
         # Ensure FK constraints AFTER the transaction commits to avoid "pending trigger events" errors
-        # We use transaction.on_commit() to ensure all deferred constraints are checked first
         if should_ensure_fk:
             def ensure_constraint():
                 self.custom_object_type._ensure_field_fk_constraint(model, self.name)