From 2a26d97c2c16278b833ebeb0f9b31fac6e297d94 Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Mon, 24 Apr 2023 18:46:50 -0300 Subject: [PATCH 1/9] Bump develop version (#672) --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a94a22638..ffda16259 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -5,7 +5,7 @@ cmake_minimum_required(VERSION 3.13) ####################################################### # this is the source of truth for semver version -project(visor VERSION 4.3.0) +project(visor VERSION 4.4.0) # for main line release, this is empty # for development release, this is "-develop" From a21a1dab35b2793488289a537c62b1498eda716f Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Wed, 26 Apr 2023 10:58:35 -0300 Subject: [PATCH 2/9] [fix] pktvisor report tests --- .github/workflows/build-develop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-develop.yml b/.github/workflows/build-develop.yml index e841417d2..8e912ab3a 100644 --- a/.github/workflows/build-develop.yml +++ b/.github/workflows/build-develop.yml @@ -644,7 +644,7 @@ jobs: key: ${{ secrets.RUNNER_SSH_KEY }} port: 2022 source: "./output/*" - target: "/usr/share/nginx/html/pktvisor/develop/${{ needs.integration-tests.outputs.commit_hash }}/pktvisor/python-test" + target: "/usr/share/nginx/html/test_data/pktvisor/develop/${{ needs.integration-tests.outputs.commit_hash }}/pktvisor/python-test" remove-github-runner-amd64: continue-on-error: true From 644ef857c16fc8e9b6b01a92f9081710cc7ab788 Mon Sep 17 00:00:00 2001 From: Leonardo Parente Date: Sun, 30 Apr 2023 09:58:36 -0400 Subject: [PATCH 3/9] Add nullptr validation on GeoDB class (#675) --- src/GeoDB.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/GeoDB.cpp b/src/GeoDB.cpp index f898e0abc..9b3f0b2fc 100644 --- a/src/GeoDB.cpp +++ b/src/GeoDB.cpp @@ -52,7 +52,7 @@ MaxmindDB::~MaxmindDB() City MaxmindDB::getGeoLoc(const struct sockaddr *sa) const { - if (!_enabled) { + if (!_enabled || sa == nullptr) { return {}; } @@ -69,7 +69,7 @@ City MaxmindDB::getGeoLoc(const struct sockaddr *sa) const City MaxmindDB::getGeoLoc(const struct sockaddr_in *sa4) const { - if (!_enabled) { + if (!_enabled || sa4 == nullptr) { return {}; } @@ -106,7 +106,7 @@ City MaxmindDB::getGeoLoc(const struct sockaddr_in *sa4) const City MaxmindDB::getGeoLoc(const struct sockaddr_in6 *sa6) const { - if (!_enabled) { + if (!_enabled || sa6 == nullptr) { return {}; } @@ -143,7 +143,7 @@ City MaxmindDB::getGeoLoc(const struct sockaddr_in6 *sa6) const City MaxmindDB::getGeoLoc(const char *ip_address) const { - if (!_enabled) { + if (!_enabled || ip_address == nullptr) { return {}; } @@ -262,7 +262,7 @@ std::string MaxmindDB::getASNString(const struct sockaddr *sa) const std::string MaxmindDB::getASNString(const struct sockaddr_in *sa4) const { - if (!_enabled) { + if (!_enabled || sa4 == nullptr) { return {}; } std::string ip_address; @@ -298,7 +298,7 @@ std::string MaxmindDB::getASNString(const struct sockaddr_in *sa4) const std::string MaxmindDB::getASNString(const struct sockaddr_in6 *sa6) const { - if (!_enabled) { + if (!_enabled || sa6 == nullptr) { return {}; } @@ -335,7 +335,7 @@ std::string MaxmindDB::getASNString(const struct sockaddr_in6 *sa6) const std::string MaxmindDB::getASNString(const char *ip_address) const { - if (!_enabled) { + if (!_enabled || ip_address == nullptr) { return {}; } From c24bcdef94d6acfd48a62fab808f46d1bdcd049c Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Mon, 1 May 2023 16:01:45 -0300 Subject: [PATCH 4/9] [fix] remove armv7 (#674) [fix] remove armv7 (#674) --- .github/workflows/build-release.yml | 245 +--------------------------- 1 file changed, 2 insertions(+), 243 deletions(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index 828f41a69..e14e0c33f 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -255,92 +255,6 @@ jobs: path: | .github/hosted-runner/arm64/terraform.tfstate retention-days: 1 - - spinup-amd64-runner: - needs: [ prebuild-package ] - runs-on: ubuntu-latest - outputs: - runner_token: ${{ steps.token.outputs.runner }} - runner_label: ${{ env.RUNNER_LABEL }} - if: github.event_name != 'pull_request' - steps: - - name: Checkout - uses: actions/checkout@v3 - - - name: Generate runner token - id: token - run: | - curl -X POST -H "authorization: Bearer ${{ secrets.BOT_TOKEN }}" -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/orb-community/pktvisor/actions/runners/registration-token -o token.json - echo "::set-output name=runner::$(cat token.json | jq .token --raw-output )" - cat token.json - - - name: Get short commit hash to a variable - id: commit_hash - run: | - echo "::set-output name=sha_short::$(git rev-parse --short HEAD)" - - - name: Inject runner token in user_data.sh - run: | - cd .github/hosted-runner/amd64/ - ESCAPED_REPLACE_RUNNER_TOKEN=$(printf '%s\n' "${{ steps.token.outputs.runner }}" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/RUNNER_TOKEN/$ESCAPED_REPLACE_RUNNER_TOKEN/g" user_data.sh - ESCAPED_REPLACE_RUNNER_NAME=$(printf '%s\n' "${{ steps.commit_hash.outputs.sha_short }}-amd64" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/AMD64_RUNNER/$ESCAPED_REPLACE_RUNNER_NAME/g" user_data.sh - ESCAPED_REPLACE_RUNNER_LABEL=$(printf '%s\n' "${{ steps.commit_hash.outputs.sha_short }}-amd64" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/RUNNER_LABEL/$ESCAPED_REPLACE_RUNNER_LABEL/g" user_data.sh - echo "RUNNER_LABEL=${{ steps.commit_hash.outputs.sha_short }}-amd64" >> $GITHUB_ENV - - - name: Inject AWS key - run: | - cd .github/hosted-runner/amd64/ - ESCAPED_REPLACE_KEY_ID=$(printf '%s\n' "${{ secrets.AWS_ACCESS_KEY_ID }}" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/AWSID/$ESCAPED_REPLACE_KEY_ID/g" vars.tf - ESCAPED_REPLACE_ACCESS_KEY=$(printf '%s\n' "${{ secrets.AWS_SECRET_ACCESS_KEY }}" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/AWSSECRET/$ESCAPED_REPLACE_ACCESS_KEY/g" vars.tf - ESCAPED_REPLACE_ENVIRONMENT=$(printf '%s\n' "${{ needs.prebuild-package.outputs.branch_name }}-${{ steps.commit_hash.outputs.sha_short }}-release" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/ENVIRONMENT/$ESCAPED_REPLACE_ENVIRONMENT/g" vars.tf - - - name: setup terraform - uses: hashicorp/setup-terraform@v2 - with: - terraform_version: 1.1.7 - terraform_wrapper: false - - - name: Terraform Init - run: | - cd .github/hosted-runner/amd64/ - terraform init -input=false - - - name: Terraform plan - run: | - cd .github/hosted-runner/amd64/ - terraform plan -out=tfplan - - - name: Terraform apply - run: | - cd .github/hosted-runner/amd64/ - terraform apply -auto-approve tfplan - - - name: Terraform output - run: | - cd .github/hosted-runner/amd64/ - terraform output -raw ip > ip.txt - - - name: Persist IP to workspace - uses: actions/upload-artifact@v2 - with: - name: ip - path: | - .github/hosted-runner/amd64/ip.txt - retention-days: 1 - - - name: Persist to workspace - uses: actions/upload-artifact@v2 - with: - name: terraform2 - path: | - .github/hosted-runner/amd64/terraform.tfstate - retention-days: 1 build-win64: # The CMake configure and build commands are platform agnostic and should work equally @@ -428,7 +342,7 @@ jobs: retention-days: 1 build-cli-win64: - needs: [ build-win64 ] + needs: [ build-win64, release ] runs-on: ubuntu-latest steps: - name: Checkout code @@ -592,80 +506,6 @@ jobs: docker image ls -a docker push ${{ env.IMAGE_NAME }}:release-arm64 - package-armv7: - needs: [ spinup-amd64-runner ] - runs-on: ${{ needs.spinup-amd64-runner.outputs.runner_label }} - if: github.event_name != 'pull_request' - steps: - - name: Attach to workspace - uses: actions/download-artifact@v2 - with: - name: workspace - - - name: Get branch name - shell: bash - run: echo "BRANCH_NAME=$(echo ${GITHUB_REF#refs/heads/} | tr / -)" >> $GITHUB_ENV - - - name: Debug branch name - run: echo ${{ env.BRANCH_NAME }} - - - name: Get VERSION - run: | - echo "VERSION=`cat ${{github.workspace}}/build/VERSION`" >> $GITHUB_ENV - - name: Debug version - run: echo ${{ env.VERSION }} - - - name: Generate ref tag (master) - if: ${{ env.BRANCH_NAME == 'master' }} - run: | - echo "REF_TAG=latest" >> $GITHUB_ENV - echo "PRERELEASE=false" >> $GITHUB_ENV - echo "DRAFT=true" >> $GITHUB_ENV - - name: Debug ref tag - run: echo ${{ env.REF_TAG }} - - - name: Login to GitHub Container Registry - uses: docker/login-action@v1 - with: - registry: ghcr.io - username: ${{ github.repository_owner }} - password: ${{ secrets.GITHUB_TOKEN }} - - - name: Replace token - run: | - sed -i -e "s/CP_TOKEN/${{ secrets.CRASHPAD_TOKEN }}/g" docker/run.sh - - name: Replace escape url - run: | - REPLACE=${{ secrets.BUGSPLAT_CP_URL }} - ESCAPED_REPLACE=$(printf '%s\n' "$REPLACE" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/CP_URL/$ESCAPED_REPLACE/g" docker/run.sh - - - name: Set up QEMU - uses: docker/setup-qemu-action@v2 - - - name: Set up Docker Buildx - id: buildx - uses: docker/setup-buildx-action@v2 - - - name: Build + push - pktvisor (multi-arch) - env: - IMAGE_NAME: ghcr.io/orb-community/pktvisor - uses: docker/build-push-action@v3 - with: - builder: ${{ steps.buildx.outputs.name }} - context: . - file: ./docker/Dockerfile - platforms: linux/arm/v7 - tags: ${{ env.IMAGE_NAME }}:release-armv7 - outputs: type=docker,dest=/tmp/armv7.tar - - - name: Load image - env: - IMAGE_NAME: ghcr.io/orb-community/pktvisor - run: | - docker load --input /tmp/armv7.tar - docker image ls -a - docker push ${{ env.IMAGE_NAME }}:release-armv7 package-amd64: needs: [ prebuild-package ] @@ -866,88 +706,8 @@ jobs: cd .github/hosted-runner/arm64/ terraform destroy -auto-approve - remove-github-runner-amd64: - continue-on-error: true - needs: [ package-armv7 ] - runs-on: ubuntu-latest - if: github.event_name != 'pull_request' - steps: - - name: Attach to workspace - uses: actions/download-artifact@v2 - with: - name: ip - - - name: Get runner ip - id: address - run: | - ls -lha - echo "::set-output name=ip::$(cat ip.txt)" - - - name: Generate remove runner token - id: remove-token-amd64 - run: | - curl -X POST -H "authorization: Bearer ${{ secrets.BOT_TOKEN }}" -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/orb-community/pktvisor/actions/runners/remove-token -o token.json - echo "::set-output name=remove-runner::$(cat token.json | jq .token --raw-output )" - cat token.json - echo "TOKEN_RUNNER_AMD64=$(cat token.json | jq .token --raw-output )" >> $GITHUB_ENV - - - name: Executing remote ssh commands on runner - uses: appleboy/ssh-action@master - with: - host: ${{ steps.address.outputs.ip }} - username: ubuntu - key: ${{ secrets.RUNNER_SSH_KEY }} - port: 22 - script: | - cd /actions-runner - sudo chmod 777 . -R - ./config.sh remove --token ${{ env.TOKEN_RUNNER_AMD64 }} - - remove-amd64-runner: - needs: [ remove-github-runner-amd64 ] - runs-on: ubuntu-latest - if: github.event_name != 'pull_request' - steps: - - name: Checkout - uses: actions/checkout@v3 - - - name: Attach to workspace - uses: actions/download-artifact@v2 - with: - name: terraform2 - path: .github/hosted-runner/amd64/ - - - name: Inject AWS key - run: | - cd .github/hosted-runner/amd64/ - ESCAPED_REPLACE_KEY_ID=$(printf '%s\n' "${{ secrets.AWS_ACCESS_KEY_ID }}" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/AWSID/$ESCAPED_REPLACE_KEY_ID/g" vars.tf - ESCAPED_REPLACE_ACCESS_KEY=$(printf '%s\n' "${{ secrets.AWS_SECRET_ACCESS_KEY }}" | sed -e 's/[\/&]/\\&/g') - sed -i -e "s/AWSSECRET/$ESCAPED_REPLACE_ACCESS_KEY/g" vars.tf - - - name: setup terraform - uses: hashicorp/setup-terraform@v2 - with: - terraform_version: 1.1.7 - - - name: Terraform Init - run: | - cd .github/hosted-runner/amd64/ - terraform init -input=false - - - name: Terraform plan destroy - run: | - cd .github/hosted-runner/amd64/ - terraform plan -destroy - continue-on-error: true - - - name: Terraform destroy - run: | - cd .github/hosted-runner/amd64/ - terraform destroy -auto-approve - pushing-manifests: - needs: [ package-amd64 , package-arm64 , package-armv7 ] + needs: [ package-amd64 , package-arm64 ] runs-on: ubuntu-latest if: github.event_name != 'pull_request' steps: @@ -962,7 +722,6 @@ jobs: run: | docker manifest create ghcr.io/orb-community/pktvisor:latest \ ghcr.io/orb-community/pktvisor:release-amd64 \ - ghcr.io/orb-community/pktvisor:release-armv7 \ ghcr.io/orb-community/pktvisor:release-arm64 - name: Push manifest to ghcr.io From ff6e221e7bd9bb6d85111dcce4f062b5c393179b Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Tue, 2 May 2023 11:04:27 -0300 Subject: [PATCH 5/9] [Fix] app image dockerfile (#676) --- .../prometheus/docker-grafana-agent/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/centralized_collection/prometheus/docker-grafana-agent/Dockerfile b/centralized_collection/prometheus/docker-grafana-agent/Dockerfile index 59435f097..f1ab1565d 100644 --- a/centralized_collection/prometheus/docker-grafana-agent/Dockerfile +++ b/centralized_collection/prometheus/docker-grafana-agent/Dockerfile @@ -3,7 +3,7 @@ FROM grafana/agent:latest as agent FROM orbcommunity/pktvisor:${PKTVISOR_TAG} -COPY --from=agent /bin/agent /usr/local/bin/agent +COPY --from=agent /bin/grafana-agent /usr/local/bin/agent RUN apt-get update \ && apt-get install -y runit-init \ From 0feaad76591759663e4b83353a3744df97a42d46 Mon Sep 17 00:00:00 2001 From: manrodrigues Date: Tue, 2 May 2023 13:55:08 -0300 Subject: [PATCH 6/9] add autoretry to automated tests (#677) --- automated_tests/features/cleanup.feature | 1 + automated_tests/features/pktvisor.feature | 1 + 2 files changed, 2 insertions(+) diff --git a/automated_tests/features/cleanup.feature b/automated_tests/features/cleanup.feature index 7cf40670c..85f56a37b 100644 --- a/automated_tests/features/cleanup.feature +++ b/automated_tests/features/cleanup.feature @@ -1,3 +1,4 @@ +@AUTORETRY Feature: cleanup env @cleanup diff --git a/automated_tests/features/pktvisor.feature b/automated_tests/features/pktvisor.feature index 54b312e3a..3ef644287 100644 --- a/automated_tests/features/pktvisor.feature +++ b/automated_tests/features/pktvisor.feature @@ -1,3 +1,4 @@ +@AUTORETRY Feature: pktvisor tests @smoke From db46a2ba35aabefb17297c5006c1549980c2b523 Mon Sep 17 00:00:00 2001 From: Leonardo Parente <23251360+leoparente@users.noreply.github.com> Date: Fri, 2 Jun 2023 18:17:51 -0400 Subject: [PATCH 7/9] Ensure TopN _item_key label has proper value before adding opentelemetry datapoint (#678) Co-authored-by: Leonardo Parente --- src/Metrics.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Metrics.h b/src/Metrics.h index 8bb21d4ec..f5fdd38de 100644 --- a/src/Metrics.h +++ b/src/Metrics.h @@ -713,7 +713,9 @@ class TopN final : public Metric std::stringstream name_text; name_text << items[i].get_item(); l[_item_key] = name_text.str(); - _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + if (!l[_item_key].empty()) { + _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + } } else { break; } @@ -736,7 +738,9 @@ class TopN final : public Metric for (uint64_t i = 0; i < std::min(_top_count, items.size()); i++) { if (items[i].get_estimate() >= threshold) { l[_item_key] = formatter(items[i].get_item()); - _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + if (!l[_item_key].empty()) { + _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + } } else { break; } @@ -759,7 +763,9 @@ class TopN final : public Metric for (uint64_t i = 0; i < std::min(_top_count, items.size()); i++) { if (items[i].get_estimate() >= threshold) { formatter(l, _item_key, items[i].get_item()); - _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + if (!l[_item_key].empty()) { + _set_opentelemetry_data(metric->mutable_gauge()->add_data_points(), start_time, end_time, l, items[i].get_estimate()); + } } else { break; } From 10de22988ca3aff88b458c19121d423b55c807f8 Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Sat, 3 Jun 2023 13:26:28 -0300 Subject: [PATCH 8/9] disable macos build temporarily (#679) disable macos build temporarily (#679) --- .github/workflows/build-develop.yml | 66 ++++++++++++++++------------- conanfile.txt | 2 +- 2 files changed, 37 insertions(+), 31 deletions(-) diff --git a/.github/workflows/build-develop.yml b/.github/workflows/build-develop.yml index 8e912ab3a..cefa6703d 100644 --- a/.github/workflows/build-develop.yml +++ b/.github/workflows/build-develop.yml @@ -27,7 +27,13 @@ jobs: runs-on: macos-11 steps: - uses: actions/checkout@v3 - + - name: install gcc 12.2 + run: | + gcc --version + brew search gcc + brew install gcc@12 + gcc --version + - name: Create Build Environment # Some projects don't allow in-source building, so create a separate build directory # We'll use this as our working directory for all subsequent commands @@ -39,35 +45,35 @@ jobs: with: version: 1.59.0 - - name: Setup Conan Cache - uses: actions/cache@v3 - with: - path: ${{github.workspace}}/build/conan_home/ - key: conan-${{ runner.os }}-${{ hashFiles('conanfile.txt', '*/conanfile.txt') }} - restore-keys: conan-${{ runner.os }}- - - - name: Configure CMake - # Use a bash shell so we can use the same syntax for environment variable - # access regardless of the host operating system - shell: bash - working-directory: ${{github.workspace}}/build - # Note the current convention is to use the -S and -B options here to specify source - # and build directories, but this is only available with CMake 3.13 and higher. - # The CMake binaries on the Github Actions machines are (as of this writing) 3.12 - run: PKG_CONFIG_PATH=${{github.workspace}}/local/lib/pkgconfig cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE - - - name: Build - working-directory: ${{github.workspace}}/build - shell: bash - # Execute the build. You can specify a specific target with "--target " - run: cmake --build . --config $BUILD_TYPE -- -j 2 - - - name: Test - working-directory: ${{github.workspace}}/build - shell: bash - # Execute tests defined by the CMake configuration. - # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail - run: ctest -C $BUILD_TYPE +# - name: Setup Conan Cache +# uses: actions/cache@v3 +# with: +# path: ${{github.workspace}}/build/conan_home/ +# key: conan-${{ runner.os }}-${{ hashFiles('conanfile.txt', '*/conanfile.txt') }} +# restore-keys: conan-${{ runner.os }}- + +# - name: Configure CMake +# # Use a bash shell so we can use the same syntax for environment variable +# # access regardless of the host operating system +# shell: bash +# working-directory: ${{github.workspace}}/build +# # Note the current convention is to use the -S and -B options here to specify source +# # and build directories, but this is only available with CMake 3.13 and higher. +# # The CMake binaries on the Github Actions machines are (as of this writing) 3.12 +# run: PKG_CONFIG_PATH=${{github.workspace}}/local/lib/pkgconfig cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE + +# - name: Build +# working-directory: ${{github.workspace}}/build +# shell: bash +# # Execute the build. You can specify a specific target with "--target " +# run: cmake --build . --config $BUILD_TYPE -- -j 2 + +# - name: Test +# working-directory: ${{github.workspace}}/build +# shell: bash +# # Execute tests defined by the CMake configuration. +# # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail +# run: ctest -C $BUILD_TYPE unit-tests-linux: # The CMake configure and build commands are platform agnostic and should work equally diff --git a/conanfile.txt b/conanfile.txt index 71d786c6f..76e6331dc 100644 --- a/conanfile.txt +++ b/conanfile.txt @@ -19,7 +19,7 @@ uvw/2.12.1 libpcap/1.10.1 yaml-cpp/0.7.0 robin-hood-hashing/3.11.5 -zlib/1.2.11 +zlib/1.2.12 crashpad/cci.20220219 [build_requires] From 18764e591d502078e557941c4aea12da6aa74085 Mon Sep 17 00:00:00 2001 From: "Everton H. Taques" <97463920+etaques@users.noreply.github.com> Date: Tue, 6 Jun 2023 17:06:38 -0300 Subject: [PATCH 9/9] disabling macos build on release pipeline (#680) disabling macos build on release pipeline (#680) --- .github/workflows/build-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index e14e0c33f..44c6d756f 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -20,7 +20,7 @@ jobs: unit-tests: strategy: matrix: - os: [ ubuntu-latest, macos-11 ] + os: [ ubuntu-latest ] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3