Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Xcode 13.3 #70

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix for Xcode 13.3 #70

wants to merge 2 commits into from

Conversation

geoleo751
Copy link

@geoleo751 geoleo751 commented Jan 24, 2023 •
edited
Loading

This PR contains:

  • Migrate dependencies to Swift Package Manager
  • Bumped deployment versions
  • Added typealias for closures based on suggestion from @akashivskyy
  • All Unit Tests for all platforms are ✅
  • Project tested and compiles on Xcode 13.3, 13.4.1, 14.2 both on Intel and M1 base macs

mschuetz-viz and others added 2 commits March 22, 2022 18:10
@mschuetz-viz
proposal for a fix for the Xcode 13.3 - Trace/BPT trap:5 compilation …
753c034 
…error

  - uses a standard block (instead of convention(block) for printClosure in ConsoleOutputFacility.swift
  - user a standard block (instead of convention(block) for deserializationClosure in TestBodyDeserializer.swift
  - through to problems on M1, used Swift Packages (instead of Carthage) for private 3rd party dependencies in the test targets
Updated packages and deployment targets
c063d75
@geoleo751 geoleo751 changed the title Fix/xcode13 3 Fix for Xcode 13.3 Jan 25, 2023
@geoleo751 geoleo751 marked this pull request as ready for review January 25, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianMarkowski DamianMarkowski Awaiting requested review from DamianMarkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoleo751 @mschuetz-viz