Search by name #23
Open
Search by name #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgad0110
reviewed
Jun 19, 2018
| defp fetch_assets(page) do | ||
| Sejfguru.Assets.list_assets_with_users(page: page) | ||
| defp fetch_assets(page, query) do | ||
| if query do |
There was a problem hiding this comment.
this could be done by pattern matching in function, which I think is more elixir style than using conditions ;)
defp fetch_assets(page, %{} = query), do: Sejfguru.Assets.filter_assets_with_users(query: query, page: page)
defp fetch_assets(page, nil), do: Sejfguru.Assets.list_assets_with_users(page: page)| @@ -1,4 +1,10 @@ | |||
| <div class="container"> | |||
| <%= form_for @conn, asset_path(@conn, :index), [method: :get, class: "navbar-form navbar-left search"], fn f-> %> | |||
| <div class="form-group"> | |||
| <input type="text" name="search" class="form-control" placeholder="Search"> | |||
There was a problem hiding this comment.
why not use form helpers for generating text input and button? https://hexdocs.pm/phoenix_html/Phoenix.HTML.Form.html#module-with-connection-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple filtering functionality