Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Add trace attribute to track builds failing from Netlify maintained extensions #5914

Merged
merged 24 commits into from
Dec 11, 2024

Conversation

YujohnNattrass
Copy link
Contributor

@YujohnNattrass YujohnNattrass commented Nov 21, 2024

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes CPLA-2168

We would like to add monitoring for builds that fail due to Netlify-maintained extensions/plugins.

Adding the extension author helps us identify which extensions are maintained by Netlify, and including the extension slug makes it easier to find the extension in the internal admin UI.

Here is an example of the monitor. I tested it using a custom extension designed to intentionally fail a deploy during the build process.
Screenshot 2024-11-22 at 1 53 29 PM


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@YujohnNattrass YujohnNattrass changed the title feat(build): track netlify owned extensions feat(build): track when Netlify maintained extensions fail builds Nov 22, 2024
@YujohnNattrass YujohnNattrass marked this pull request as ready for review November 22, 2024 22:06
@YujohnNattrass YujohnNattrass changed the title feat(build): track when Netlify maintained extensions fail builds feat(build): Add trace attribute to track failing builds from Netlify maintained extensions/plugins Nov 22, 2024
@YujohnNattrass YujohnNattrass marked this pull request as draft November 22, 2024 23:30
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@YujohnNattrass YujohnNattrass changed the title feat(build): Add trace attribute to track failing builds from Netlify maintained extensions/plugins feat(build): Add trace attribute to track failing builds from Netlify maintained extensions Dec 4, 2024
@YujohnNattrass YujohnNattrass marked this pull request as ready for review December 4, 2024 16:29
@YujohnNattrass YujohnNattrass requested a review from a team as a code owner December 4, 2024 16:29
@YujohnNattrass YujohnNattrass changed the title feat(build): Add trace attribute to track failing builds from Netlify maintained extensions feat(build): Add trace attribute to track builds failing from Netlify maintained extensions Dec 5, 2024
@sarahetter
Copy link
Contributor

Looks like we've got failing tests here for stuff we touched.

@YujohnNattrass
Copy link
Contributor Author

YujohnNattrass commented Dec 5, 2024

@sarahetter

Looks like we've got failing tests here for stuff we touched.

these required checks are failing on main as well :( Tests are also failing on main...

Here is a thread for a little bit more context

I'll be working on getting these required checks to pass in separate PR and merge that one before this one gets merged.

I'll ask for a re-review after main is fixed.

DanielSLew
DanielSLew previously approved these changes Dec 5, 2024
Copy link
Contributor

@NikAiyer NikAiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YujohnNattrass YujohnNattrass merged commit 7e99c26 into main Dec 11, 2024
38 checks passed
@YujohnNattrass YujohnNattrass deleted the yj/track-extensions branch December 11, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants