-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): Add trace attribute to track builds failing from Netlify maintained extensions #5914
Conversation
This pull request adds or modifies JavaScript ( |
Looks like we've got failing tests here for stuff we touched. |
these required checks are failing on main as well :( Tests are also failing on main... Here is a thread for a little bit more context I'll be working on getting these required checks to pass in separate PR and merge that one before this one gets merged. I'll ask for a re-review after main is fixed. |
…into yj/track-extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes CPLA-2168
We would like to add monitoring for builds that fail due to Netlify-maintained extensions/plugins.
Adding the extension author helps us identify which extensions are maintained by Netlify, and including the extension slug makes it easier to find the extension in the internal admin UI.
Here is an example of the monitor. I tested it using a custom extension designed to intentionally fail a deploy during the build process.

For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)