Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default-param-last ESLint rule #1419

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add default-param-last ESLint rule #1419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module.exports = {
'consistent-this': 2,
'default-case': 2,
'default-case-last': 2,
'default-param-last': 2,
'func-name-matching': [2, { considerPropertyDescriptor: true }],
'func-names': [2, 'as-needed'],
'max-classes-per-file': 2,
Expand Down
2 changes: 1 addition & 1 deletion src/commands/functions/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ async function createFunctionAddon({ api, addons, siteId, addonName, siteData, l
}
}

async function installAddons(context, functionAddons = [], fnPath) {
async function installAddons(context, functionAddons, fnPath) {
if (functionAddons.length === 0) {
return
}
Expand Down
2 changes: 1 addition & 1 deletion src/utils/proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function initializeProxy(port, distDir, projectDir) {
return handlers
}

async function startProxy(settings = {}, addonUrls, configPath, projectDir) {
async function startProxy(settings, addonUrls, configPath, projectDir) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings cannot be undefined here.

const functionsServer = settings.functionsPort ? `http://localhost:${settings.functionsPort}` : null

const proxy = initializeProxy(settings.frameworkPort, settings.dist, projectDir)
Expand Down