Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @netlify/zip-it-and-ship-it to v4.28.3 #3533

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 25, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@netlify/zip-it-and-ship-it 4.26.1 -> 4.28.3 age adoption passing confidence

Release Notes

netlify/zip-it-and-ship-it

v4.28.3

Compare Source

v4.28.2

Compare Source

v4.28.1

Compare Source

v4.28.0

Compare Source

Features
Bug Fixes

v4.27.0

Compare Source

Features
4.26.1 (2021-10-20)
Bug Fixes
  • take repositoryRoot into account when computing base path with esbuild (#​754) (8b2f8ea)

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 25, 2021
@github-actions
Copy link

github-actions bot commented Oct 25, 2021

📊 Benchmark results

Comparing with 83fa812

Package size: 362 MB

⬇️ 0.37% decrease vs. 83fa812

^  358 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  357 MB  362 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll handle this one.

eduardoboucas
eduardoboucas previously approved these changes Oct 26, 2021
@renovate renovate bot dismissed stale reviews from eduardoboucas and kodiakhq[bot] via 40c292a November 2, 2021 18:51
@renovate renovate bot force-pushed the renovate/netlify-zip-it-and-ship-it-4.x branch from b3cb455 to 40c292a Compare November 2, 2021 18:51
@renovate renovate bot changed the title fix(deps): update dependency @netlify/zip-it-and-ship-it to v4.27.0 fix(deps): update dependency @netlify/zip-it-and-ship-it to v4.28.3 Nov 2, 2021
@eduardoboucas eduardoboucas merged commit a1a238b into main Nov 2, 2021
@eduardoboucas eduardoboucas deleted the renovate/netlify-zip-it-and-ship-it-4.x branch November 2, 2021 19:11
@eduardoboucas
Copy link
Member

eduardoboucas commented Nov 2, 2021

@benmccann This has been released as v6.14.10. I'm really sorry for the delay on getting this one out. I hope everything is working as expected for SvelteKit now, please let us know if you're still seeing any issue. Thanks for your patience!

@benmccann
Copy link

Thank you so much! Is this deployed to the production Netlify pipeline now?

My deploys are still failing unfortunately

(Example):

12:27:40 PM: ────────────────────────────────────────────────────────────────
12:27:40 PM: Dependencies installation error
12:27:40 PM: ────────────────────────────────────────────────────────────────
12:27:40 PM: ​
12:27:40 PM: Error message
12:27:40 PM: A Netlify Function failed to require one of its dependencies.
12:27:40 PM: Please make sure it is present in the site's top-level "package.json".

12:27:40 PM: In file "/opt/build/repo/.netlify/functions-internal/__render.js"
12:27:40 PM: Cannot find module 'stream/package.json'
12:27:40 PM: Require stack:
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/bundlers/zisi/resolve.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/bundlers/zisi/traverse.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/bundlers/esbuild/src_files.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/bundlers/esbuild/index.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/bundlers/index.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/node/index.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/runtimes/index.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/zip-it-and-ship-it/dist/main.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/build/src/plugins_core/functions/index.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/build/src/steps/get.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/build/src/core/main.js
12:27:40 PM: - /opt/buildhome/node-deps/node_modules/@netlify/build/src/core/bin.js

@netlify-team-account-1
Copy link
Contributor

Hey @benmccann. I followed the steps in https://github.com/sveltejs/kit/tree/master/packages/adapter-netlify and was able to deploy this site without any changes: https://618397dd4cf799a601f16c4a--sveltekit-repro-netlify-adapter-esm.netlify.app/. Could you verify the problem still occurs for you, and possibly share another reproduction repository? Let's get this solved 🙌

@benmccann
Copy link

Thanks for taking a look! It does appear to be working now. It seems I had to do "clear cache and deploy" to get it to work and just a simple git push alone wouldn't work, which is why it was failing for me originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants