-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(command-dev): optionally pass settings to getNetlifyGraphConfig #4132
Merged
kodiakhq
merged 2 commits into
main
from
fix-dev-graph-breaking-on-repeat-port-detection
Jan 25, 2022
Merged
fix(command-dev): optionally pass settings to getNetlifyGraphConfig #4132
kodiakhq
merged 2 commits into
main
from
fix-dev-graph-breaking-on-repeat-port-detection
Jan 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an issue where the detectServerSettings calls acquirePort twice and ends up blowing up by making sure we only run the detection once within netlify dev
📊 Benchmark resultsComparing with 4e5eb1a Package size: 360 MB⬇️ 0.00% decrease vs. 4e5eb1a
Legend
|
erezrokah
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @biilmann 🚀
kodiakhq
bot
deleted the
fix-dev-graph-breaking-on-repeat-port-detection
branch
January 25, 2022 13:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When starting
netlify dev --graph
in a new remix project, I would run into:Turns out this happens because
getNetlifyGraphConfig
runs after thedev
command has already started a server on port 3000 and then use
detectServerSettings
which includes a call to
acquirePort
and cause the startup to fail.This makes sure that
detectServerSettings
only runs one duringnetlify dev