-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make deploy command bundle edge functions #4562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiewmacharia
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Apr 25, 2022
jackiewmacharia
commented
Apr 25, 2022
Failing tests will be fixed once new build package is available from PR netlify/build#4271 |
jackiewmacharia
changed the title
Make deploy command bundle edge functions
feat: make deploy command bundle edge functions
Apr 25, 2022
…etlify/cli into feat/make-deploy-bundle-edge-functions
📊 Benchmark resultsComparing with 73b2d6a Package size: 285 MB⬇️ 0.00% decrease vs. 73b2d6a
Legend
|
This reverts commit f2ca95a.
eduardoboucas
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackiewmacharia I pushed 707b122 as per our chat. If there's anything that you'd like to change, please feel free to do so.
This was referenced May 25, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Add to Kodiak auto merge queue
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ntl deploy
is called without the--build
flag to ensure file changes reflect.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)