fix: move try catch to prepareServer

[jackiewmacharia]

🎉 Thanks for submitting a pull request! 🎉

Summary

Related to #4621

• Looks like we are going to have to have to move the initializeProxy try/catch to prepareServer after all - I've ran into a situation during testing where prepareServer breaks before it gets to Promise.all - on linux-aarch64. Because we don't await on prepareServer, it's possible that a binary error could be thrown at a different point in time breaking netlify dev before we have a chance to catch it in initializeProxy.

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[github-actions]

📊 Benchmark results

Comparing with 55d7013

Package size: 221 MB

⬇️ 0.00% decrease vs. 55d7013

^  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB  226 MB         
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐   221 MB 
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (55d7013): 221 MB
• T-29 (80df246): 221 MB
• T-28 (f8cc372): 221 MB
• T-27 (ea91c62): 221 MB
• T-26 (282add9): 221 MB
• T-25 (e0695f9): 221 MB
• T-24 (7dedadc): 221 MB
• T-23 (63d4520): 221 MB
• T-22 (f341e05): 221 MB
• T-21 (b4d6eef): 221 MB
• T-20 (85db12b): 221 MB
• T-19 (b00ad87): 221 MB
• T-18 (f36f0fc): 221 MB
• T-17 (8c127b8): 221 MB
• T-16 (9b6adad): 221 MB
• T-15 (bbb9638): 221 MB
• T-14 (68c4abf): 221 MB
• T-13 (9f68c05): 221 MB
• T-12 (d10b135): 226 MB
• T-11 (2bdfa82): 226 MB
• T-10 (9dffdb0): 226 MB
• T-9 (cd947d1): 226 MB
• T-8 (f8b8063): 226 MB
• T-7 (442186e): 226 MB
• T-6 (ee7f986): 226 MB
• T-5 (49018be): 226 MB
• T-4 (9ab3cd6): 226 MB
• T-3 (b09b86e): 226 MB
• T-2 (a67ec05): 226 MB
• T-1 (7857dae): 226 MB
• T (current commit): 221 MB

[jackiewmacharia]

@eduardoboucas @danez I may have ran into a use case for the try/catch in prepareServer instead of initializeProxy (details in PR description).

[eduardoboucas]

• Looks like we are going to have to have to move the initializeProxy try/catch to prepareServer after all - I've ran into a situation during testing where prepareServer breaks before it gets to Promise.all

Can you help me understand what leads to this? If prepareServer throws, then the Promise.all will reject and our existing try/catch will kick in. What am I missing?

[jackiewmacharia]

Follow up from the pairing call, I've tested this branch against both scenarios and it works for both:

[jackiewmacharia]

@eduardoboucas this one's ready

[eduardoboucas]

🚀