chore: migrate everything to ESM #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 21d9191 Package size: 259 MB(no change) Legend
|
danez
commented
Jan 5, 2023
| }) | ||
| }) | ||
|
|
||
| test.skipIf(process.platform === 'win32')( |
There was a problem hiding this comment.
This was skipped before too, but from what I looked at seems like a problem with either in how we use netlify/config in the cli or a problem inside netlify/config on windows. And is definitely not a flaky test as stated before, just a broken one :)
❯ tests/integration/520.command.link.test.mjs (2 tests | 1 failed) 16162ms
❯ tests/integration/520.command.link.test.mjs > should create gitignore in repository root when cwd is subdirectory
⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
→ Command failed with exit code 1: D:\a\cli\cli\bin\run.mjs link
FAIL tests/integration/520.command.link.test.mjs > should create gitignore in repository root when cwd is subdirectory
Configuration property "build.base" "..\..\..\..\..\..\..\..\runneradmin\AppData\Local\Temp\netlify-cli-tests-v18.12.1\5976\7f60040b-6d53-401b-9749-9964421586b0\monorepo\projects\project1" must be inside the repository root directory.
Error: Command failed with exit code 1: D:\a\cli\cli\bin\run.mjs link
Configuration property "build.base" "..\..\..\..\..\..\..\..\runneradmin\AppData\Local\Temp\netlify-cli-tests-v18.12.1\5976\7f60040b-6d53-401b-9749-9964421586b0\monorepo\projects\project1" must be inside the repository root directory.
khendrikse
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last ESM PR for the
srccodebase. There are no commonjs files anymore in in thesrcfolder after this PR. (except templates for functions/sites, which I did not touch)There are still some cjs test files, which I want to convert separately, as I also have some Ideas on how to improve them.