-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: b64-encode geo location in local dev #5873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -85,7 +85,7 @@ | |||
"@netlify/framework-info": "9.8.10", | |||
"@netlify/local-functions-proxy": "1.1.1", | |||
"@netlify/serverless-functions-api": "1.5.1", | |||
"@netlify/zip-it-and-ship-it": "9.13.0", | |||
"@netlify/zip-it-and-ship-it": "9.13.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to include a ZISI update as part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because that contains the updated @netlify/serverless-functions-api
🎉 Thanks for submitting a pull request! 🎉
Summary
Part of https://github.com/netlify/pod-dev-foundations/issues/558. Makes sure that the geo location is encoded as b64 before being passed into headers, similar to how we'll do it in prod.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)