Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: b64-encode geo location in local dev #5873

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Jul 17, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Part of https://github.com/netlify/pod-dev-foundations/issues/558. Makes sure that the geo location is encoded as b64 before being passed into headers, similar to how we'll do it in prod.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt Skn0tt requested a review from a team as a code owner July 17, 2023 13:19
@Skn0tt Skn0tt self-assigned this Jul 17, 2023
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

📊 Benchmark results

Comparing with 2c9d8f9

  • Dependency count: 1,320 ⬆️ 1.59% increase vs. 2c9d8f9
  • Package size: 275 MB ⬆️ 1.64% increase vs. 2c9d8f9

lukasholzer
lukasholzer previously approved these changes Jul 19, 2023
Copy link
Collaborator

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -85,7 +85,7 @@
"@netlify/framework-info": "9.8.10",
"@netlify/local-functions-proxy": "1.1.1",
"@netlify/serverless-functions-api": "1.5.1",
"@netlify/zip-it-and-ship-it": "9.13.0",
"@netlify/zip-it-and-ship-it": "9.13.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include a ZISI update as part of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because that contains the updated @netlify/serverless-functions-api

@Skn0tt Skn0tt merged commit faa6ad2 into main Jul 20, 2023
@Skn0tt Skn0tt deleted the local-dev-geo-base64+ branch July 20, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants