Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov: remove token, turn off CI failure #667

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented May 27, 2024

See also: netobserv/network-observability-console-plugin#531

Also, align the workflow file with other repos

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels May 27, 2024
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak requested a review from OlivierCazade May 27, 2024 09:04
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.52%. Comparing base (fdb4eb1) to head (e6acd78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files         104      104           
  Lines        6658     6658           
=======================================
  Hits         4429     4429           
  Misses       1915     1915           
  Partials      314      314           
Flag Coverage Δ
unittests 66.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jotak jotak requested a review from msherif1234 May 27, 2024 09:20
@jotak jotak merged commit b3a3a82 into netobserv:main May 28, 2024
10 of 11 checks passed
@jotak jotak deleted the fix-codecov branch May 28, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant