Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-site export #84

Closed
scotho3 opened this issue Nov 10, 2023 · 5 comments · Fixed by #88
Closed

Allow multi-site export #84

scotho3 opened this issue Nov 10, 2023 · 5 comments · Fixed by #88
Labels
enhancement New feature or request feature request New capability requested by the community

Comments

@scotho3
Copy link
Contributor

scotho3 commented Nov 10, 2023

Having a single site is nice, but for backbones or other large interconnected networks, having a single topology showing all sites, or multiple sites would be helpful.

@bortok
Copy link
Contributor

bortok commented Nov 10, 2023

Scott, could you propose how the CLI command would look like? Also, if the sites are disconnected (two or more graphs) would that change anything in the export logic? Note, today nrx does not export standalone devices (w/o connections to other devices in the same export group).

@scotho3
Copy link
Contributor Author

scotho3 commented Nov 10, 2023

./nrx.py --sites site1,site2,site3 ... was what I had in mind.

The primary change is just making nb_site into a list named nb_sites

If they're not connected, they're not connected, I think the default behavior for standalone devices is fine, although I could make an argument for showing them.

https://github.com/scotho3/nrx - is an example.

@bortok
Copy link
Contributor

bortok commented Nov 12, 2023

Thomas, if you would create a PR, I shall be able to test it next weekend and give more feedback. Thank you for the suggestion!

@bortok bortok added the enhancement New feature or request label Nov 12, 2023
@bortok bortok added this to the WAN Topologies milestone Nov 12, 2023
@bortok
Copy link
Contributor

bortok commented Nov 25, 2023

Hi @scotho3 , would you be able to create a PR for this?

@scotho3
Copy link
Contributor Author

scotho3 commented Nov 25, 2023

Hi @bortok - sorry, I was away from my email for an extended holiday, PR has been opened.

@bortok bortok added the feature request New capability requested by the community label Nov 26, 2023
@bortok bortok linked a pull request Nov 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request New capability requested by the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants