Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take max width into account on save #61

Closed
muh-nr opened this issue Aug 16, 2019 · 3 comments · Fixed by #96
Closed

Take max width into account on save #61

muh-nr opened this issue Aug 16, 2019 · 3 comments · Fixed by #96
Labels
bug wip work in progress

Comments

@muh-nr
Copy link
Contributor

muh-nr commented Aug 16, 2019 •
edited
Loading

Since TYPO3 9 $magicImageService->createMagicImage(...) does not use max width/height values for image rendering
@tmotyl
Copy link
Contributor

tmotyl commented Apr 7, 2020

@muh-nr @aphex13 what do you mean?
What has changed in v9 and where? how does it influence the process of inserting images in RTE?

@mcmulman
Copy link
Contributor

mcmulman commented Oct 5, 2020

@tmotyl you'r right, nothing changed, everything works.
Don't know what has been wrong...

@mcmulman mcmulman closed this as completed Oct 5, 2020
@mcmulman mcmulman reopened this Oct 5, 2020
@mcmulman
Copy link
Contributor

mcmulman commented Oct 5, 2020 •
edited
Loading

The problem occured when saving an fce with images. Then the max values haven't been taken into account.
But it's nothing about the magicImageService.

mcmulman added a commit that referenced this issue Oct 5, 2020
@mcmulman
[BUGFIX] #61: Respect max width and height configuration for images w…
19e0602 
…hen saving element
@mcmulman mcmulman mentioned this issue Oct 5, 2020
Merged
@mcmulman mcmulman added bug wip work in progress labels Oct 5, 2020
@Gitsko Gitsko closed this as completed in #96 Oct 6, 2020
Gitsko added a commit that referenced this issue Oct 6, 2020
@Gitsko
Merge pull request #96 from netresearch/issue-61_respect-max-width
40da856 
[BUGFIX] #61: Respect max width and height configuration for images w…
mcmulman added a commit that referenced this issue Oct 12, 2020
@mcmulman
[BUGFIX] #61: Respect max width and height configuration for images w…
084e352 
…hen saving element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug wip work in progress
Projects
None yet
Milestone
No milestone
3 participants
@tmotyl @muh-nr @mcmulman