-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unchecking enlarge on click not working #69
Comments
I encounter the same problem having TYPO3 version 9.5.13 and rte_ckeditor_image version 9.0.4.. I select the image in the CKEditor and choose the "Image properties". In the shown overlay page, I enter the desired values:
I then hit ok. When I look at the source code it has correct set
It seems to me, that the values are not getting into the bodytext of the tt_content element correctly.Then I thought: What if I change the values in the Source Code view of the CKEditor? I changed the following attributes and clicked "Save":
The rendering itselfs also seems to have troubles displaying values correctly.Then I removed the "data-htmlarea-zoom" attribute completly, which resulted in no link around the images in the frontend. EDIT: I see... Maybe "zoom" ist not "clickenlarge". But there is no "clickenlarge" attribute when returning from the overlay image configuration. Only a "data-htmlarea-zoom" attribute. |
Hey people, You can check if this is good enough, tested on 10.4.5 LTS and if ($zoom.prop('checked')) {
// When saving the zoom property is saved as the new `zoom` attribute
attributes['data-htmlarea-zoom'] = true
// If unchecked, remove zoom attributes
} else if (attributes['data-htmlarea-zoom'] || attributes['data-htmlarea-clickenlarge']) {
attributes = null
}
return attributes |
[BUGFIX] #69: Remove zoom attributes when checkbox is disabled
Use Case in
TYPO3 9.5.9 - LTS
rte_ckeditor_image - 9.0.3
Added an image with a popup in the ckeditor by enabling enlarge on click checkbox. It saves correctly in the CKEditor with the data-zoom attribute as true.
But when unchecking
enlarge on click
this data-zoom attribute persists & unable to save the same image without a popup.The text was updated successfully, but these errors were encountered: