Do not log twice to console

Author: Christoph Lehmann

Classes/Handler/DebugExceptionHandler.php

@@ -6,6 +6,7 @@
 use Neos\Flow\Log\ThrowableStorageInterface;
 use Neos\Flow\ObjectManagement\ObjectManagerInterface;
 use Networkteam\SentryClient\ErrorHandler;
+use Networkteam\Util\Log\ThrowableStorage\ConsoleStorage;
 
 class DebugExceptionHandler extends DebugExceptionHandlerBase
 {
@@ -27,7 +28,11 @@ public function handleException($exception)
 
         $exceptionWasLogged = false;
         if ($this->throwableStorage instanceof ThrowableStorageInterface && isset($this->renderingOptions['logException']) && $this->renderingOptions['logException']) {
-            $this->throwableStorage->logThrowable($exception, ['sentryEventId' => $eventId]);
+            $message = $this->throwableStorage->logThrowable($exception, ['sentryEventId' => $eventId]);
+            // ConsoleStorage logs json to the console like the other loggers, so do not log twice.
+            if (!$this->throwableStorage instanceof ConsoleStorage) {
+                $this->logger->critical($message);
+            }
             $exceptionWasLogged = true;
         }
 

Classes/Handler/ProductionExceptionHandler.php

@@ -6,6 +6,7 @@
 use Neos\Flow\Log\ThrowableStorageInterface;
 use Neos\Flow\ObjectManagement\ObjectManagerInterface;
 use Networkteam\SentryClient\ErrorHandler;
+use Networkteam\Util\Log\ThrowableStorage\ConsoleStorage;
 
 class ProductionExceptionHandler extends ProductionExceptionHandlerBase
 {
@@ -28,7 +29,11 @@ public function handleException($exception)
 
         $exceptionWasLogged = false;
         if ($this->throwableStorage instanceof ThrowableStorageInterface && isset($this->renderingOptions['logException']) && $this->renderingOptions['logException']) {
-            $this->throwableStorage->logThrowable($exception, ['sentryEventId' => $eventId]);
+            $message = $this->throwableStorage->logThrowable($exception, ['sentryEventId' => $eventId]);
+            // Our ConsoleStorage logs json to the console like the other loggers, so do not log twice.
+            if (!$this->throwableStorage instanceof ConsoleStorage) {
+                $this->logger->critical($message);
+            }
             $exceptionWasLogged = true;
         }