Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLTK model downloads #760

Closed
davidmezzetti opened this issue Aug 10, 2024 · 2 comments
Closed

Update NLTK model downloads #760

davidmezzetti opened this issue Aug 10, 2024 · 2 comments
Assignees
Milestone

Comments

@davidmezzetti
Copy link
Member

The latest version of NTLK introduced a few breaking changes in regards to the model downloading procedure. The build and examples should be updated to fix these.

@davidmezzetti davidmezzetti added this to the v7.4.0 milestone Aug 10, 2024
@davidmezzetti davidmezzetti self-assigned this Aug 10, 2024
@davidmezzetti davidmezzetti reopened this Aug 15, 2024
@davidmezzetti
Copy link
Member Author

nltk 3.8.2 was deleted from PyPI given these breaking changes. So it looks like this change needs to be reverted until the next stable nltk release.

davidmezzetti added a commit that referenced this issue Aug 15, 2024
davidmezzetti added a commit that referenced this issue Aug 15, 2024
@davidmezzetti davidmezzetti changed the title Upgrade NLTK Update NLTK model downloads Aug 16, 2024
@davidmezzetti
Copy link
Member Author

A change will be put in to download both the old and new models. This will support both the current (3.8.1) and future versions that require the new models.

txtai can be updated a later time to require the new version of NLTK and only use the new models, once NLTK finalizes the path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant