Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PHASE__ and STAGE__ column schema with step column #157

Open
7 of 9 tasks
alyssadai opened this issue Sep 20, 2024 · 0 comments
Open
7 of 9 tasks

Replace PHASE__ and STAGE__ column schema with step column #157

alyssadai opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
schema Updating input schema for improved generalizability or usability

Comments

@alyssadai
Copy link
Collaborator

alyssadai commented Sep 20, 2024

Change allows input imaging bagels to be fully long format

  • step column should be required and have no missing values (?)

  • remove HAS_DATATYPE__ and HAS_IMAGE__ columns for now (this info will probably be part of a different file in Nipoppy, or added back with different column names in future)

  • remove MissingValue column property

  • remove the has_mri_data column

  • use pipeline-version-step instead of pipeline-version for tracking completion

  • update plot of records x pipeline status so every pipeline-version-step combination has a separate bar

  • update READMEs

  • update QPN data files

    • was the nipoppy/qpn repo moved?
  • double check status descriptions

  • keep the incomplete / unavailable statuses

Q's:

  • corresponding changes in phenotypic file identifier columns, to make sure they are named the same way? yes
@alyssadai alyssadai added the schema Updating input schema for improved generalizability or usability label Sep 20, 2024
@alyssadai alyssadai added this to the Input schema refactor milestone Sep 20, 2024
@alyssadai alyssadai self-assigned this Dec 9, 2024
@alyssadai alyssadai changed the title Replace PHASE__ and STAGE__ column schema with STEP column Replace PHASE__ and STAGE__ column schema with step column Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Updating input schema for improved generalizability or usability
Projects
Status: No status
Development

No branches or pull requests

1 participant