From 8f4c5c2e4c38cb0d71045801f69c67d819715771 Mon Sep 17 00:00:00 2001 From: Alyssa Dai Date: Mon, 13 Nov 2023 15:30:09 -0500 Subject: [PATCH] [ENH] Clarify PR merging responsibility (#124) * clarify PR merge responsibility * better differentiate PRs internal vs. external to developer team --- docs/contributing/pull_requests.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/contributing/pull_requests.md b/docs/contributing/pull_requests.md index 39edc12d..40bbe2dc 100644 --- a/docs/contributing/pull_requests.md +++ b/docs/contributing/pull_requests.md @@ -22,7 +22,7 @@ Instead, for documentation content changes, the following prefixes can be used t - `[FIX]`: Fixing errors in the documentation ## Pull request reviews -A developer will review each PR and may provide comments or suggestions for the PR author to address. +A core maintainer will review each PR and may provide comments or suggestions for the PR author to address. Neurobagel PR reviews may use the following emoji signifiers: @@ -31,3 +31,8 @@ Neurobagel PR reviews may use the following emoji signifiers: :cherries:: Some optional/suggested changes that could be nice to have but are not required to merge If (required) changes are requested, the PR author should re-request a review from the reviewer once the comments have been addressed. + +### When your pull request is approved +If you **are not a member of the Neurobagel developer team**: the reviewing Neurobagel maintainer is responsible for merging the PR. + +If you **are a member of the Neurobagel developer team** (i.e., you have write access to the repository): the PR author is responsible for merging the PR.